Ampers: Abinnet Ainalem (Basic requirements met)

[Abiaina]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What was the purpose of the initialize method in your class?	To prime my class with the info necessary for it to define its variables and methods at the specific instance of the class it is set to.
Describe an instance variable you used and what you used it for.	I used the instance variable name to store the names of the planets.
Describe what the difference would be if your SolarSystem used an Array vs a Hash.	I would have to change one of the methods in the SolarSystem to set the instance variables for name, orbit etc to obtain the info from an array and not a hash. It would work but I would have to change some things in my code
Do you feel like you used consistent formatting throughout your code?	No, I just barely put it all together and didn't have time to make sure everything was formatted correctly. I had an issue with how I did an array of hashes I don't think the formatting is right....I looked for examples on stackoverflow and ruby docs and settled on the one I have now.

[CheezItMan]

Thanks!

[CheezItMan]

Why is this indented?!!

In the future before submitting use Atom's autoindent feature!

[CheezItMan]

A couple of things here:

1. You're initializing solar_system with an array of hashes and NOT an array of Planet instances!
2. You're re-creating the SolarSystem instance each time the loop repeats. That's a bit inefficient. Only put code in a loop that needs to be there.

[CheezItMan]

Why show the planet names in all caps and then downcase the user entry?

[CheezItMan]

Do you need 2 instance variables? This looks like it should be a local variable holding an array of planet names (and numbers).

[CheezItMan]

Good

[CheezItMan]

This method should just return a list of planet names, not add elements to another instance variable. If you hadn't recreated the SolarSystem each iteration of the main loop you would end up with double and triple entries for each planet in @ ranked_planets.

[CheezItMan]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Readable code with consistent indentation.	As you mentioned, you didn't indent consistently.
Primary Requirements
Created Custom Solar System Class with initialize, add planet & list planets methods, without using puts.	Well done here
Planet Class Created	Check
Created a collection of Planet objects as an instance variable in SolarSystem.	Your SolarSystem instance does NOT use Planet instances.
Accessor methods created	Check, although you used attr_accessor for everything and your code doesn't need to give the user write access attr_reader would be better.
Method created to return the Planet's attributes and not use puts	Check
Created a user interface to interact with the SolarSystem including adding a planet and viewing a planet's details	Check,
Additional Notes	You hit most of the requirements, but see my in-line notes The biggest issue is that your SolarSystem doesn't use the Planet class at all.