Octos - Hannah Cameron - Solar System#42
Open
hannahlcameron wants to merge 1 commit intoAda-C9:masterfrom
Open
Octos - Hannah Cameron - Solar System#42hannahlcameron wants to merge 1 commit intoAda-C9:masterfrom
hannahlcameron wants to merge 1 commit intoAda-C9:masterfrom
Conversation
Solar SystemWhat We're Looking For
|
CheezItMan
reviewed
Feb 13, 2018
| # initializes solar system | ||
| my_solar_system = SolarSystem.new(planet_list) | ||
|
|
||
| puts "Welcome to the Solar System 2000, where you can learn information about the planets in the database or you can add in your own planets!" |
There was a problem hiding this comment.
It would be good to put this in some kind of loop that would let us to look at a number of planets.
|
|
||
| my_solar_system.add_planet(Planet.new("#{new_planet_name}", new_planet_terraform_state, "#{new_planet_temperature}", "#{new_planet_atmosphere}", "#{new_planet_location}")) | ||
|
|
||
| puts "You just added #{new_planet_name} as a planet, which located in the #{new_planet_location} galaxy. It is a #{new_planet_temperature} planet, whose atmosphere is #{new_planet_atmosphere} to humans." |
There was a problem hiding this comment.
#{new_planet_name} is the Planet instance, not the name of the planet. It's printing "#Planet:0x00007fe7f48a9718" instead of whatever planet name I choose. Instead you should probably use #{new_planet_name.name}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solar System
Congratulations! You're submitting your assignment.
Comprehension Questions
initializemethod in your class?SolarSystemused anArrayvs aHash.