submitting Solar System?

[brittanyrjones]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What was the purpose of the initialize method in your class?
Describe an instance variable you used and what you used it for.
Describe what the difference would be if your SolarSystem used an Array vs a Hash.
Do you feel like you used consistent formatting throughout your code?

[CheezItMan]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Readable code with consistent indentation.	No See my in-line notes.
Primary Requirements
Created Custom Solar System Class with initialize, add planet & list planets methods, without using puts.	You have initialize and add_planet methods, but initialize is broken. The method to list planets also mixes roles (see my inline notes).
Planet Class Created	Check
Created a collection of Planet objects as an instance variable in SolarSystem.	You tried, but initialize is broken.
Accessor methods created	Yes, but these should probably be attr_reader rather than attr_accessor.
Method created to return the Planet's attributes and not use puts	Sort-f you have an accessor that returns a hash and the main program uses this. However by doing this there's little reason to use a class. Instead why not just use a hash.
Created a user interface to interact with the SolarSystem including adding a planet and viewing a planet's details	The interface is created, but you're not using the numbers in the interface, so it's counterintuitive. You're also not using the SolarSystem class in the interface!
Additional Notes	No answers to comprehension questions! This is a problematic submission. I know you had computer issues, but seeing how SolarSystem isn't used in the interface (and the fact that it's broken), is a bit worrying. For now focus on Word-Guess and try to put in place the concepts you had trouble with here, constructors, and separating roles in your classes. If you have questions lets sit down and look at things.

[CheezItMan]

This file should end with .rb

[CheezItMan]

Code inside a class should be indented. Either use 1 tab or 2 spaces to indent code.

Also why make this a hash or an accessor?

By being a hash a user of Planet must know the structure of the hash and they keys.

By using attr_accessor you are giving users the ability to change @planet_hash. You probably don't want to do that.

Granted in this project it's a minor issue.

[CheezItMan]

Similar issue with making this an acessor.

[CheezItMan]

You are blanking out @planets so anything sent into initialize is erased.

Also your initialize method isn't getting sent a parameter.

You should have:

def initialize(planets)
  @planets = planets
end

[CheezItMan]

weird indentation here with end

[CheezItMan]

You're doing what's called mixing roles here. Each class should focus on one role. SolarSystem should deal with storing planets and returning a list of planet names. Planet should store planet details and provide getter methods.

The main program's methods can deal with Input and output to the screen. That separation of roles can make things easier to reuse and modify.

[CheezItMan]

You're not using the SolarSystem instance!