Kirsten and Victoria - Ampers - Video Store API

[Lasiorhine]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We went through the seeds and examined the relationships they implied. We then refined that a few times during the coding process.
Describe a set of positive and negative test cases you implemented for a model.	For the movies_checked_out_count method in the Customer model, we wrote tests for situations in which customers had (1) No previous, completed rentals and no current open rentals; (2) No previous, completed rentals, but one or more open rentals; (3) Previous, completed rentals and no current, open rentals; (4) .both previous, completed rentals and current, open rentals.
Describe a set of positive and negative test cases you implemented for a controller.	For the movie show method, we created tests for both situations where the client provides good data about a movie, and for when the client provides bad data.
How does your API respond when bad data is sent to it?	It returns customized error messages.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We created a custom model method for in movie for available_inventory. We approached it that way because it involved a calculation, and that kind of operation really doesn't belong in the controller, so the model was the only reasonable place to put it.
Do you have any recommendations on how we could improve this project for the next cohort?	QC the Postman tests a little more, maybe?
Link to Trello	Join the board with this link: https://trello.com/invite/b/VHz5pYkG/4516c3f8f7967efcfc119c182a665006/videostoreapi
Link to ERD	https://www.lucidchart.com/invitations/accept/b20739b5-9d6b-48aa-ac9b-e93ff6fd6a18

[CheezItMan]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits, good commit messages, both partner contributing
Comprehension questions	Check
General
Business Logic in Models	Check
All required endpoints return expected JSON data	Check
Requests respond with appropriate HTTP Status Code	Check
Errors are reported	Check
Testing
Passes all Smoke Tests	. Check
Model Tests - all relations, validations, and custom functions test positive & negative cases	Check
Controller Tests - URI parameters and data in the request body have positive & negative cases	Missing RentalsController testing,
Overall	Overall well done, you hit the major learning goals. Nice work! You are now finished with Rails!

[CheezItMan]

Hellooooo, :)

[CheezItMan]

tests...