Karinna Iniguez - API Muncher - Octos#22
Open
karinnainiguez wants to merge 24 commits intoAda-C9:masterfrom
Open
Karinna Iniguez - API Muncher - Octos#22karinnainiguez wants to merge 24 commits intoAda-C9:masterfrom
karinnainiguez wants to merge 24 commits intoAda-C9:masterfrom
Conversation
API MuncherWhat We're Looking For
|
|
|
||
| root 'recipes#search' | ||
| get 'recipes', to: 'recipes#index', as: 'results' | ||
| get 'recipe/:id', to: 'recipes#show', as: 'recipe' |
There was a problem hiding this comment.
Could you use resources for the index and show pages?
| @@ -0,0 +1,25 @@ | |||
| <header> | |||
| <%= render partial: 'search_form' %> | |||
| </header> | |||
There was a problem hiding this comment.
Since you include the search form on every page, it might make sense to put it in application.html.erb.
|
|
||
| <section class="search-form"> | ||
| <h1><%= link_to "YUMMMMSTER", root_path %></h1> | ||
| <%= form_tag results_path, method: :get do %> |
There was a problem hiding this comment.
Good use of a view partial to DRY this up.
| recipe = Recipe.new(response[0]) | ||
| return recipe | ||
| else | ||
|
|
There was a problem hiding this comment.
You should probably have something in this else clause - return nil or throw an exception.
|
|
||
| def show | ||
| @recipe = EdamamApiWrapper.single_search(params[:id]) | ||
| end |
There was a problem hiding this comment.
What if the search fails? Your page should probably report the failure to the user.
| it "responds with success for search with no results" do | ||
| VCR.use_cassette("recipes") do | ||
| query = "something that doesnt exist" | ||
| get results_path, params: {query: query} |
There was a problem hiding this comment.
Good job catching this error case!
There was a problem hiding this comment.
It might also be worthwhile to add some tests around the paging parameters:
- What happens if they're absent?
- Do you get different results when they change?
- What if you send a bogus value, like a negative page number?
| describe "show" do | ||
| it "responds with success" do | ||
| VCR.use_cassette("recipes") do | ||
| id = "67b2867627c159e4f5bbaf2431b3ccb6" |
| it "returns single recipe if searching single" do | ||
| VCR.use_cassette("recipes") do | ||
| id = "67b2867627c159e4f5bbaf2431b3ccb6" | ||
| response = EdamamApiWrapper.single_search(id) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions