Ampers Abinnet

[Abiaina]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I went to the documents page and looked for examples online using the api, also used postman a lot
Describe your API Wrapper. How did you decide on the methods you created?	My wrapper creates a new instance of recipe and there is an individual wrapper for creating many recipes and creating a single recipe instance
Describe an edge case or failure case test you wrote for your API Wrapper.	Update: I tested if the wrapper was given invalid query from params and if the page or from value was also invalid. I tested that the last item on a page is also made an instance of the recipe class. Past comment: I did not finish testing, but the edge cases I explored were trying to create a new instance of recipe with limited parameters. Also Making an invalid get request using invalid query and page number(from= value)
Explain how VCR aids in testing an API.	It copies responses of the api as I make requests on them for testing and helps prevent me from over using the api and exceeding my limit (this happened a lot and I had to get new keys)
What is the Heroku URL of your deployed application?	Update: It works!! (but almost no css) Past comment: it doesn't work past the search page. I want to continue working on it tonight/later today. https://chicken-muncher.herokuapp.com/
Provide a link to the Trello board you used	https://trello.com/b/tuGLq06T/apimuncher

[CheezItMan]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit mesages
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	Your index action uses path /recipes/index, when it should use /recipes instead. The show action should be on path /recipes/:uri.
Semantic HTML	Less div elements and more semantic HTML tags please.
Errors are reported to the user	It reports a confusing message when the search results are empty. It crashes when the show action is given an invalid URI
API Wrapper to handle the API requests	Check
Controller testing	You have all your controller tests in test/lib/recipe_test.rb. So you have a lot of problems with them passing.
Lib testing	You've mixed the Recipe class and Wrapper testing.
Search Functionality	It works
List Functionality	It works
Show individual item functionality (link to original recipe opens in new tab)	It works, it doesn't open the source in a new tab (minor issue)
Styling
Responsive layout	Minimal styling
List View shows 10 items at a time/pagination	Check
The app is styled to create an attractive user interface	Minimal styling
API Features
The App attributes Edaman	Check
The VCR cassettes do not contain the API key	Check
External Resources
Link to Trello Board	Check
Link to deployed app on Heroku	Check
Overall	You had the basic functionality working, but with serious problems in your testing. I'd like you to take 10 minutes to review it with me or your tutor. You really should how to setup proper tests, even if you can't write tests to cover all circumstances. I do appreciate how you stuck with working on this after the due date. That shows the dedication you'll need in this career.

[CheezItMan]

This file is for testing the lib files, not controllers.

That's why all these tests are failing.

[CheezItMan]

You need an if statement to verify that the get request worked.

[CheezItMan]

Probably a bit of both. I do think that recipe_details should be nil here not false