Skip to content

Brenda Rios - Hotel - Octos#19

Open
brendarios wants to merge 32 commits intoAda-C9:masterfrom
brendarios:master
Open

Brenda Rios - Hotel - Octos#19
brendarios wants to merge 32 commits intoAda-C9:masterfrom
brendarios:master

Conversation

@brendarios
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? At the beginning, my original design included a class for Rooms, but while I was building the pseudocode, tests and the code I realized that my Rooms class was not having a lot of behavior in my project, and that the set up of the rooms will never change so I decided to avoid using a Rooms class, and included in the Booking class the set up of the rooms.
Describe a concept that you gained more clarity on as you worked on this assignment. this project help me to think more about the overall design and think about the importance of deciding the responsibility of each class
Describe a nominal test that you wrote for this assignment. when I tested in my Booking class if it creates a list of reservations and tested if the list of reservations equal to an Array and if responded to :reservations_list
Describe an edge case test that you wrote for this assignment. I tested my block rooms considering only 4 rooms were blocked. So, after 4 reservations of block rooms, I tested if the method raises an error if no more blocked rooms are available.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? As you can see on my commits, in this project I used more pseudocode as in previous projects and I feel this, and also, making most of the tests first, help me to have a good final coverage %

lib/booking.rb Outdated
module Hotel

Amount_Rooms_Hotel = 20
Max_Block_Rooms = 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constants should be all caps

@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes. I really like the fact that you created a separate class to handle date range logic.
Demonstrated loose coupling Yes - you did a nice job trying to keep the logic for unrelated portions of the code separated out.
Methods demonstrate a good use of encapsulation, inputs and outputs Yes, looks good
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants