Ampers - Abinnet by Abiaina · Pull Request #41 · Ada-C9/hotel

Abiaina · 2018-03-12T19:35:41Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	Deciding to make a room class or just an array of room ids. Talking it over with Chris during our on-on-one and in class when I recognized that the room class is just holding very little info.
Describe a concept that you gained more clarity on as you worked on this assignment.	I improved on design, I used more flow charts/ mapping to come up with a basic design, then wrote the tests and continuously ran the tests as I wrote the code itself.
Describe a nominal test that you wrote for this assignment.	testing if a reservation is able to be made when dates are given and there is available rooms
Describe an edge case test that you wrote for this assignment.	Testing if a reservation is able to be made when dates are given but there are no more available rooms. Trying to book more than 20 rooms in a single date range.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I actually liked it, the pseudo code part on whiteboards was really helpful in determining edge cases and what variables/parameters I would use for specific methods.

…e testing

…iry by date

…ation start and end dates

…values and create reservation instances

…ost instance variable in reservation an admin spec.

…ation instances array returns booked room id

…ects with a specifc date, tests pass for intersect and no date intersects

…ay in admin

…failing

…ion to existing reservations prevents double booking

…ing with existing reservations

… to new room for reservation attempts to rooms that are already booked

…ot reassign new booking to another room

… block, most testing completed

…m ids, all tests all passing

CheezItMan · 2018-03-19T01:44:10Z

Hotel

What We're Looking For

Feature	Feedback
Design
Demonstrated classes having a single responsibility	For the most part, your `Admin` class is doing a bit much, but overall pretty good.
Demonstrated loose coupling	Very good work here, `Admin` depends on `Reservation` and `Block`, and `Block` depends on `Reservation`
Methods demonstrate a good use of encapsulation, inputs and outputs	Pretty good, see my comments.
Wave 1 requirements	Check
Wave 2 requirements	Check, but you have a bug in your logic, see my notes.
Wave 3 requirements	Check
Summary	Nice work, you showed a lot of growth here in design. Overall nicely done. You have some bugs in your code, but the design is pretty good overall. Checkout our reference implementation

CheezItMan · 2018-03-19T01:24:03Z

lib/admin.rb

+      raise ArgumentError.new("#{room_id} is booked for these dates")
+    end
+
+    if available_rooms.count == 0


Ummm.. if there were no rooms then available_rooms would not include room_id.

CheezItMan · 2018-03-19T01:25:37Z

lib/admin.rb

+    @reservations.each do |reservation|
+      valid_check_in = check_in.between?(reservation.start_date, (reservation.end_date - 1))
+
+      valid_check_out = check_out.between?((reservation.start_date + 1), reservation.end_date)


What about if the reservation occurs entirely between check_in and check_out?

CheezItMan · 2018-03-19T01:27:50Z

lib/admin.rb

+    @reservations << Reservation.new(check_in, check_out, room_id)
+  end
+
+  def available_rooms(check_in, check_out)


To have wave 3 complete you may also need to check the blocks, or make sure add_reservation considers blocks.

CheezItMan · 2018-03-19T01:32:48Z

lib/reservation.rb

@@ -0,0 +1,47 @@
+require 'date'
+
+class Reservation


I would suggest a method in reservation which either takes a Reservation or a date range and returns true if it overlaps with this reservation and false if it does not. It might make the logic easier in Admin.

CheezItMan · 2018-03-19T01:34:03Z

specs/spec_admin.rb

+    @bookings[0].room_id.must_equal 1
+  end
+
+  it "calculates the length of stay" do


This is really a test of the Reservation class.

CheezItMan · 2018-03-19T01:39:57Z

specs/spec_block.rb

+  end
+
+  it "add reservation adds reservation to reservations list" do
+    before_rezs =  @blockroom_test.reservations.dup


I'm unsure why you need to duplicate the array.

…d admin class

Abiaina added 25 commits March 5, 2018 14:33

tests written and passed for room and admin class

963ba6c

room, admin, reservation classes passing tests; most of wave 1 completed

881a7d5

completed admin code for generating new reservations, missing adequat…

48a4ce0

…e testing

some tests pass, missing wave 1 price at reservation and booking inqu…

5860f19

…iry by date

passes test, most of wave 1 completed

5531ef5

admin and reservation decoupled, confirms valid date entry for reserv…

224e90e

…ation start and end dates

reservation class instantiated

c166e23

removed room instances from admin, updated testing for admin to take …

1a453d0

…values and create reservation instances

calculate reservation cost in reservation cost, testing for calling c…

58a770e

…ost instance variable in reservation an admin spec.

books reservation from 2 dates, assigns room, testing confirms reserv…

d7a17f8

…ation instances array returns booked room id

can search for reservations with check-in/check-out range that inters…

dd6e2d1

…ects with a specifc date, tests pass for intersect and no date intersects

removed room class

46f2d1c

return room id by reservation, corrected testing for reservations arr…

d0f6177

…ay in admin

testing for availble rooms by date outline

e659624

determines available rooms for certain date ranges, test written and …

467cf83

…failing

available_rooms logic fixed, tests updated and passing

45dbe06

outline testing for updates to add_reservation, compares new reservat…

81e50a1

…ion to existing reservations prevents double booking

completed most of testing for making new reservation without conflict…

b2adbf4

…ing with existing reservations

argument error raised for reservations attempted in fully booked hotel

8782399

testing completed for preventing double assigning the same room

317c6f7

raises argument for no available rooms reservation attempt, reassigns…

47cf59b

… to new room for reservation attempts to rooms that are already booked

raises argument error when attempting to book a reserved room, does n…

ca58274

…ot reassign new booking to another room

block class created and testing for block class started

d6ecd15

admin can block rooms, set variable rate, reserve rooms in and out of…

cab4d12

… block, most testing completed

error fixed using .dup, removed code that removes list of blocked roo…

96f08c2

…m ids, all tests all passing

CheezItMan reviewed Mar 19, 2018

View reviewed changes

Abiaina added 3 commits April 1, 2018 19:36

answered design-activity prompts

ea49bb3

created outline for design improvements decoupling the reservation an…

19c7d16

…d admin class

removed instance variable price from admin class

d9a1374

moved logic for new reservation of block into block_room class

d44fc34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ampers - Abinnet#41

Ampers - Abinnet#41
Abiaina wants to merge 29 commits intoAda-C9:masterfrom
Abiaina:master

Abiaina commented Mar 12, 2018

Uh oh!

CheezItMan commented Mar 19, 2018 •

edited

Loading

Uh oh!

CheezItMan Mar 19, 2018

Uh oh!

CheezItMan Mar 19, 2018

Uh oh!

CheezItMan Mar 19, 2018

Uh oh!

CheezItMan Mar 19, 2018

Uh oh!

CheezItMan Mar 19, 2018

Uh oh!

CheezItMan Mar 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Abiaina commented Mar 12, 2018

Hotel

Comprehension Questions

Uh oh!

CheezItMan commented Mar 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hotel

What We're Looking For

Uh oh!

CheezItMan Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CheezItMan commented Mar 19, 2018 •

edited

Loading