Skip to content

Mariko A. Ampers C9#42

Open
marikoja wants to merge 5 commits intoAda-C9:masterfrom
marikoja:master
Open

Mariko A. Ampers C9#42
marikoja wants to merge 5 commits intoAda-C9:masterfrom
marikoja:master

Conversation

@marikoja
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? Deciding on classes was a huge decision while working on this project. I spoke a lot of the choices out loud to make my choices more clear.
Describe a concept that you gained more clarity on as you worked on this assignment. This project has helped me understand better was is-a and has-a relationships.
Describe a nominal test that you wrote for this assignment. An example of a nominal test is when I check of a date range that I have already booked.
Describe an edge case test that you wrote for this assignment. An edge case example is when I make 20 bookings and then try one more to be sure they cannot book again.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? I found the pseudocode half helpful and half distracting. But I did feel I was becoming more comfortable with writing the tests outlines before writing code.

@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes. Nice job starting to use inheritance for the block/reservation concepts.
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements Incomplete

You should be committing using git much much more often! Your classes and methods are named well and are clearly written. Watch out for duplication within your test code - look for opportunities to keep this code clean & clear as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants