Skip to content

Kat Eastman - Hotel - Octos#43

Open
kseastman wants to merge 33 commits intoAda-C9:masterfrom
kseastman:master
Open

Kat Eastman - Hotel - Octos#43
kseastman wants to merge 33 commits intoAda-C9:masterfrom
kseastman:master

Conversation

@kseastman
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? Deciding whether or not to have separate classes to handle the logic for dates and for rooms. In theory all of the logic for each could be handled without creating a class, but it made sense to create a namespace for the date logic.
Describe a concept that you gained more clarity on as you worked on this assignment. Enumerables feel a little less abstract, inheritance is still a little hazy, but I feel more comfortable with find, find_all and map/collect.
Describe a nominal test that you wrote for this assignment. Most of my initial tests are nominal, just checking to make sure that the program is doing what it should. I start by working in pry, and when I get frustrated having to input the same setup, I'll write a test.
Describe an edge case test that you wrote for this assignment. I wrote an edge case test for accepting dates in string instead of parsed.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? I don't think I did that well, I did the pseudocode, but that is not what I ended up going with in the end. Some of my tests were written before I wrote my production code, but some of the tests happened after I wrote the code.

kseastman added 28 commits March 1, 2018 09:34
… already because they made sense, the others will be made shortly.
…gs for that day, tested to confirm functionality.
@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes - I like the way you separated out the duration logic.
Demonstrated loose coupling yes - even though the BookingManager contains a lot of logic, it is utilizing good functionality within each class.
Methods demonstrate a good use of encapsulation, inputs and outputs Yes
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants