Skip to content

Fix buffer overflow #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nadia-Adaptive wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix buffer overflow #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0beda5
Add failing test for countersMetadataBuffer capacity
Nadia-Adaptive Jan 21, 2026
6676dee
Use correct field offset for CreateCountersMetaDataBuffer
Nadia-Adaptive Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/Adaptive.Aeron.Tests/CncFileDescriptorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
using NUnit.Framework;
using Adaptive.Agrona.Util;
using Adaptive.Agrona.Concurrent;
using Adaptive.Agrona;
using System.IO;

namespace Adaptive.Aeron.Tests
{
class CncFileDescriptorTest
{
[Test]
[Ignore("Media driver needs to be running")]
public void ShouldAllocateCapacityForCounterMetadataBuffer()
{
string aeronDir = Aeron.Context.GetAeronDirectoryName();

MappedByteBuffer cncByteBuffer = IoUtil.MapExistingFile(
Path.Combine(aeronDir, "cnc.dat"), MapMode.ReadOnly);

UnsafeBuffer metadataBuffer = CncFileDescriptor.CreateMetaDataBuffer(cncByteBuffer);

UnsafeBuffer countersValueBuffer = CncFileDescriptor.CreateCountersValuesBuffer(cncByteBuffer, metadataBuffer);
UnsafeBuffer countersMetadataBuffer = CncFileDescriptor.CreateCountersMetaDataBuffer(cncByteBuffer, metadataBuffer);

Assert.AreEqual(Tests.countersMetadataBufferLength(countersValueBuffer.Capacity), countersMetadataBuffer.Capacity);
}
}
}
2 changes: 1 addition & 1 deletion src/Adaptive.Aeron/CncFileDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ public static UnsafeBuffer CreateCountersMetaDataBuffer(MappedByteBuffer buffer,
metaDataBuffer.GetInt(TO_CLIENTS_BUFFER_LENGTH_FIELD_OFFSET);

return new UnsafeBuffer(buffer.Pointer, offset,
metaDataBuffer.GetInt(TO_CLIENTS_BUFFER_LENGTH_FIELD_OFFSET));
metaDataBuffer.GetInt(COUNTERS_METADATA_BUFFER_LENGTH_FIELD_OFFSET));
}

/// <summary>
Expand Down