Skip to content

Conversation

@AlexandrPkhm
Copy link

Add a list of Windows apps with known compatibility issues

@AlexandrPkhm AlexandrPkhm self-assigned this Oct 21, 2025
@AlexandrPkhm AlexandrPkhm requested a review from zebrum October 21, 2025 13:07
Copy link
Member

@ameshkov ameshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this format, check how it's done in Android. We may need structured data in the future.

You should also add the description to README

@AlexandrPkhm AlexandrPkhm requested a review from ameshkov October 21, 2025 21:52
@adbuker adbuker marked this pull request as draft October 22, 2025 13:29
## What AdGuard applications use these filtering lists?

Currently, they apply to AdGuard for Android.
Currently, they apply to AdGuard for Android and AdGuard for Windows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для макоси и клишных блокеров не актуально?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пока нет, так как в них еще не реализован System wide filtering

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Windows-specific compatibility configuration lists to this repo so AdGuard for Windows can consume them alongside the existing Android lists.

Changes:

  • Added Windows app exclusion lists for routing and filtering behavior.
  • Added a Windows browser list used to enable HTTPS filtering by default for specific browsers.
  • Updated README to document Windows compatibility configuration files and their JSON schema.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
windows/routing_exclusions.json New list of Windows apps whose traffic should not be routed through AdGuard.
windows/filtering_exclusions.json New list of Windows apps whose traffic filtering should be disabled.
windows/browsers.json New list of browsers + install-detection conditions for enabling HTTPS filtering by default.
README.md Documents Windows config files and the common JSON entry structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AlexandrPkhm AlexandrPkhm marked this pull request as ready for review February 10, 2026 15:16
adbuker and others added 7 commits February 10, 2026 18:35
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants