add the Consent field as specified in OpenRTB 2.6 #4
Conversation
y9mo
requested review from
a team,
Baumanar,
SynRJ,
Copilot,
florianberthier and
kinnou02
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR adds the Consent field to the User struct to comply with OpenRTB 2.6 specification requirements for GDPR compliance. The field stores the Transparency and Consent Framework's Consent String data structure when GDPR regulations apply.
- Adds
Consentstring field to theUserstruct with proper JSON serialization tag - Includes comprehensive documentation explaining the field's purpose in GDPR context
- Maintains proper field ordering with
Extfield remaining last
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 20
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| strategy: | ||
| matrix: | ||
| go-version: [1.18.x, 1.19.x] | ||
| go-version: [1.18.x, 1.19.x, 1.25.x] |
There was a problem hiding this comment.
Bug: Organization-specific CI runner accidentally committed in unrelated PR
The PR description indicates this change adds the Consent field to OpenRTB, but the CI workflow was modified to use gha-rtg-adikteev-runners (an organization-specific self-hosted runner) and includes 1.25.x in the Go version matrix. These changes appear unintentionally included since they're unrelated to the stated PR purpose and would cause CI failures for contributors without access to the custom runner infrastructure.
y9mo
force-pushed
the
rico/ARP-8163-consent-from-proper-field
branch
from
87805c6 to
21ed812
Compare
y9mo
force-pushed
the
rico/ARP-8163-consent-from-proper-field
branch
from
21ed812 to
9090543
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| strategy: | ||
| matrix: | ||
| go-version: [1.18.x, 1.19.x] | ||
| go-version: [1.18.x, 1.19.x, 1.25.x] |
There was a problem hiding this comment.
The Go version matrix jumps from 1.19.x directly to 1.25.x, skipping versions 1.20.x through 1.24.x. This creates a testing gap for intermediate Go versions. Consider including 1.20.x through 1.24.x in the matrix, or at minimum testing with the latest stable version to ensure compatibility across the version range.
| go-version: [1.18.x, 1.19.x, 1.25.x] | |
| go-version: [1.18.x, 1.19.x, 1.20.x, 1.21.x, 1.22.x, 1.23.x, 1.24.x, 1.25.x] |
| with: | ||
| go-version: 1.x | ||
| cache: true | ||
| go-version: 1.19.x |
There was a problem hiding this comment.
The golangci-lint job's Go version was changed from 1.x (which always uses the latest stable Go version) to a pinned version 1.19.x. This is inconsistent with adding Go 1.25.x to the test matrix. If the project now supports Go 1.25.x, the linter should run on a compatible or newer version. Consider using 1.x to always use the latest Go version, or update to at least 1.25.x to match the highest version being tested.
| go-version: 1.19.x | |
| go-version: 1.25.x |
| CustomData string `json:"customdata,omitempty"` // Optional feature to pass bidder data that was set in the exchange's cookie. The string must be in base85 cookie safe characters and be in any format. Proper JSON encoding must be used to include "escaped" quotation marks. | ||
| Geo *Geo `json:"geo,omitempty"` | ||
| Data []Data `json:"data,omitempty"` | ||
| Consent string `json:"consent,omitempty"` // When GDPR regulations are in effect this attribute contains the Transparency and Consent Framework's Consent String data structure. |
There was a problem hiding this comment.
The new Consent field lacks test coverage. Consider adding a test case that includes the consent field in one of the existing JSON fixtures (e.g., testdata/breq.banner.json or testdata/breq.exp.json) and verify it's correctly serialized/deserialized. This is particularly important for GDPR compliance features to ensure the field is properly handled.
y9mo
force-pushed
the
rico/ARP-8163-consent-from-proper-field
branch
2 times, most recently
from
0375f03 to
18c8e22
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
y9mo
force-pushed
the
rico/ARP-8163-consent-from-proper-field
branch
from
18c8e22 to
01fec53
Compare
Note
Adds
User.consentfield per OpenRTB 2.6, fixes testerrors.Isargument order, and updates CI runner/matrix and golangci-lint action.User.consenttoopenrtb.Userper OpenRTB 2.6.errors.Isargument order inaudio_test.go,bid_test.go,bidrequest_test.go,bidresponse_test.go,impression_test.go,seatbid_test.go,video_test.go.gha-rtg-adikteev-runners-large-amd64and expand Go matrix to1.18.x,1.19.x,1.25.xin.github/workflows/test.yml.1.19.xand bumpgolangci/golangci-lint-actiontov6.Written by Cursor Bugbot for commit 01fec53. This will update automatically on new commits. Configure here.