Sourcery refactored master branch #1

sourcery-ai · 2022-01-03T13:04:15Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2022-01-03T13:04:17Z

mem_profile_old.py

    process = psutil.Process(os.getpid())
-    mem = process.get_memory_info()[0] / float(2 ** 20)
-    return mem
+    return process.get_memory_info()[0] / float(2 ** 20)


Function memory_usage_psutil refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-01-03T13:04:17Z

mem_profile_old.py

-    mem = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss / rusage_denom
-    return mem
+        rusage_denom *= rusage_denom
+    return resource.getrusage(resource.RUSAGE_SELF).ru_maxrss / rusage_denom


Function memory_usage_resource refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-01-03T13:04:17Z

random_data.py

@@ -1,4 +1,5 @@
 ''' Super simple module to create basic random data for tutorials'''
+


Lines 14-14 refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

sourcery-ai · 2022-01-03T13:04:17Z

BeautifulSoup/scrape.py

-csv_file = open('cms_scrape.csv', 'w')
+with open('cms_scrape.csv', 'w') as csv_file:
+    csv_writer = csv.writer(csv_file)
+    csv_writer.writerow(['headline', 'summary', 'video_link'])

-csv_writer = csv.writer(csv_file)
-csv_writer.writerow(['headline', 'summary', 'video_link'])
+    for article in soup.find_all('article'):
+        headline = article.h2.a.text
+        print(headline)

-for article in soup.find_all('article'):
-    headline = article.h2.a.text
-    print(headline)
+        summary = article.find('div', class_='entry-content').p.text
+        print(summary)

-    summary = article.find('div', class_='entry-content').p.text
-    print(summary)
+        try:
+            vid_src = article.find('iframe', class_='youtube-player')['src']

-    try:
-        vid_src = article.find('iframe', class_='youtube-player')['src']
+            vid_id = vid_src.split('/')[4]
+            vid_id = vid_id.split('?')[0]

-        vid_id = vid_src.split('/')[4]
-        vid_id = vid_id.split('?')[0]
+            yt_link = f'https://youtube.com/watch?v={vid_id}'
+        except Exception as e:
+            yt_link = None

-        yt_link = f'https://youtube.com/watch?v={vid_id}'
-    except Exception as e:
-        yt_link = None
+        print(yt_link)

-    print(yt_link)
+        print()

-    print()
-
-    csv_writer.writerow([headline, summary, yt_link])
-
-csv_file.close()
+        csv_writer.writerow([headline, summary, yt_link])


Lines 9-37 refactored with the following changes:

Use with when opening file to ensure closure (ensure-file-closed)

sourcery-ai · 2022-01-03T13:04:17Z

Django_Blog/07-Login-Logout-Authentication/django_project/users/views.py

-            messages.success(request, f'Your account has been created! You are now able to log in')
+            messages.success(
+                request,
+                'Your account has been created! You are now able to log in',
+            )
+


Function register refactored with the following changes:

Replace f-string with no interpolated values with string (remove-redundant-fstring)

sourcery-ai · 2022-01-03T13:04:19Z

Django_Blog/11-Pagination/django_project/users/views.py

-            messages.success(request, f'Your account has been updated!')
+            messages.success(request, 'Your account has been updated!')


Function profile refactored with the following changes:

Replace f-string with no interpolated values with string (remove-redundant-fstring)

sourcery-ai · 2022-01-03T13:04:19Z

Django_Blog/12-Password-Reset/django_project/blog/views.py

-        if self.request.user == post.author:
-            return True
-        return False
+        return self.request.user == post.author


Function PostUpdateView.test_func refactored with the following changes:

Simplify conditional into return statement (return-identity)

sourcery-ai · 2022-01-03T13:04:19Z

Django_Blog/12-Password-Reset/django_project/blog/views.py

-        if self.request.user == post.author:
-            return True
-        return False
+        return self.request.user == post.author


Function PostDeleteView.test_func refactored with the following changes:

Simplify conditional into return statement (return-identity)

sourcery-ai · 2022-01-03T13:04:19Z

Django_Blog/12-Password-Reset/django_project/users/views.py

-            messages.success(request, f'Your account has been created! You are now able to log in')
+            messages.success(
+                request,
+                'Your account has been created! You are now able to log in',
+            )
+


Function register refactored with the following changes:

Replace f-string with no interpolated values with string (remove-redundant-fstring)

sourcery-ai · 2022-01-03T13:04:19Z

Django_Blog/12-Password-Reset/django_project/users/views.py

-            messages.success(request, f'Your account has been updated!')
+            messages.success(request, 'Your account has been updated!')


Function profile refactored with the following changes:

Replace f-string with no interpolated values with string (remove-redundant-fstring)

sourcery-ai · 2022-01-03T13:04:22Z

Django_Blog/13-AWS-S3-Uploads/django_project/blog/views.py

-        if self.request.user == post.author:
-            return True
-        return False
+        return self.request.user == post.author


Function PostUpdateView.test_func refactored with the following changes:

Simplify conditional into return statement (return-identity)

sourcery-ai · 2022-01-03T13:04:22Z

Django_Blog/13-AWS-S3-Uploads/django_project/blog/views.py

-        if self.request.user == post.author:
-            return True
-        return False
+        return self.request.user == post.author


Function PostDeleteView.test_func refactored with the following changes:

Simplify conditional into return statement (return-identity)

sourcery-ai · 2022-01-03T13:04:22Z

Django_Blog/13-AWS-S3-Uploads/django_project/users/views.py

-            messages.success(request, f'Your account has been created! You are now able to log in')
+            messages.success(
+                request,
+                'Your account has been created! You are now able to log in',
+            )
+


Function register refactored with the following changes:

Replace f-string with no interpolated values with string (remove-redundant-fstring)

sourcery-ai · 2022-01-03T13:04:23Z

Django_Blog/13-AWS-S3-Uploads/django_project/users/views.py

-            messages.success(request, f'Your account has been updated!')
+            messages.success(request, 'Your account has been updated!')


Function profile refactored with the following changes:

Replace f-string with no interpolated values with string (remove-redundant-fstring)

sourcery-ai · 2022-01-03T13:04:23Z

Django_Blog/13-Deployment-Heroku/django_project/blog/views.py

-        if self.request.user == post.author:
-            return True
-        return False
+        return self.request.user == post.author


Function PostUpdateView.test_func refactored with the following changes:

Simplify conditional into return statement (return-identity)

sourcery-ai · 2022-01-03T13:04:24Z

Generators/mem_profile.py

-    mem = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss / rusage_denom
-    return mem
+        rusage_denom *= rusage_denom
+    return resource.getrusage(resource.RUSAGE_SELF).ru_maxrss / rusage_denom


Function memory_usage_resource refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2022-01-03T13:04:24Z

Object-Oriented/3-Class-Static-Methods/oop.py

-        if day.weekday() == 5 or day.weekday() == 6:
-            return False
-        return True
+        return day.weekday() not in [5, 6]


Function Employee.is_workday refactored with the following changes:

Simplify conditional into return statement (return-identity)

Replace multiple comparisons of same variable with in operator (merge-comparisons)

sourcery-ai · 2022-01-03T13:04:24Z

Object-Oriented/4-Inheritance/oop-finish.py

-            self.employees = []
-        else:
-            self.employees = employees
+        self.employees = [] if employees is None else employees


Function Manager.__init__ refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2022-01-03T13:04:25Z

Python/Iterators-Coding-Problem/iter-demo.py

 def sentence(sentence):
-    for word in sentence.split():
-        yield word
+    yield from sentence.split()


Function sentence refactored with the following changes:

Replace yield inside for loop with yield from (yield-from)

sourcery-ai · 2022-01-03T13:04:25Z

Python/Matplotlib/09-LiveData/data_gen.py

-        total_1 = total_1 + random.randint(-6, 8)
-        total_2 = total_2 + random.randint(-5, 6)
+        total_1 += random.randint(-6, 8)
+        total_2 += random.randint(-5, 6)


Lines 32-33 refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

sourcery-ai · 2022-01-03T13:04:27Z

Python/YouTube-API/02-Playlist-Duration/playlist.py

-    for item in pl_response['items']:
-        vid_ids.append(item['contentDetails']['videoId'])
-
+    vid_ids = [item['contentDetails']['videoId'] for item in pl_response['items']]


Lines 28-31 refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

sourcery-ai · 2022-01-03T13:04:28Z

Python/YouTube-API/03-Most-Popular-Video-Playlist/start.py

-    for item in pl_response['items']:
-        vid_ids.append(item['contentDetails']['videoId'])
-
+    vid_ids = [item['contentDetails']['videoId'] for item in pl_response['items']]


Lines 23-26 refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

sourcery-ai · 2022-01-03T13:04:28Z

Python-Future-Date/credit.py

-    if balance < 0:
-        balance = 0
-
+    balance = max(balance, 0)


Lines 21-23 refactored with the following changes:

Replace comparison with min/max call (min-max-identity)

sourcery-ai · 2022-01-03T13:04:28Z

Python-JSON/api.py

 # print(json.dumps(data, indent=2))

-usd_rates = dict()
+usd_rates = {}


Lines 11-11 refactored with the following changes:

Replace dict() with {} (dict-literal)

sourcery-ai · 2022-01-03T13:04:28Z

Python-Random/random_data.py

@@ -1,4 +1,5 @@
 ''' Super simple module to create basic random data for tutorials'''
+


Lines 14-14 refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

sourcery-ai · 2022-01-03T13:04:28Z

Starting_Code/employee.py

    def __init__(self, first, last, pay, employees=None):
        super().__init__(first, last, pay)
-        self.employees = employees if employees else []
+        self.employees = employees or []


Function Manager.__init__ refactored with the following changes:

Simplify if expression by using or (or-if-exp-identity)

sourcery-ai · 2022-01-03T13:04:37Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 0.38%.

Quality metrics	Before	After	Change
Complexity	2.73 ⭐	2.48 ⭐	-0.25 👍
Method Length	33.72 ⭐	32.84 ⭐	-0.88 👍
Working memory	6.98 🙂	6.90 🙂	-0.08 👍
Quality	79.01% ⭐	79.39% ⭐	0.38% 👍

Other metrics	Before	After	Change
Lines	1065	1058	-7

Changed files	Quality Before	Quality After	Quality Change
mem_profile_old.py	90.23% ⭐	93.57% ⭐	3.34% 👍
random_data.py	51.32% 🙂	51.32% 🙂	0.00%
BeautifulSoup/scrape.py	64.47% 🙂	67.04% 🙂	2.57% 👍
Django_Blog/07-Login-Logout-Authentication/django_project/users/views.py	82.18% ⭐	82.31% ⭐	0.13% 👍
Django_Blog/08-Profile-And-Images/django_project/users/views.py	82.18% ⭐	82.31% ⭐	0.13% 👍
Django_Blog/09-Update-User-Profile/django_project/users/views.py	72.59% 🙂	72.74% 🙂	0.15% 👍
Django_Blog/10-Posts-Create-Update-Delete/django_project/blog/views.py	95.11% ⭐	96.70% ⭐	1.59% 👍
Django_Blog/10-Posts-Create-Update-Delete/django_project/users/views.py	72.59% 🙂	72.74% 🙂	0.15% 👍
Django_Blog/11-Pagination/django_project/blog/views.py	95.36% ⭐	96.75% ⭐	1.39% 👍
Django_Blog/11-Pagination/django_project/users/views.py	72.59% 🙂	72.74% 🙂	0.15% 👍
Django_Blog/12-Password-Reset/django_project/blog/views.py	95.36% ⭐	96.75% ⭐	1.39% 👍
Django_Blog/12-Password-Reset/django_project/users/views.py	72.59% 🙂	72.74% 🙂	0.15% 👍
Django_Blog/13-AWS-S3-Uploads/django_project/blog/views.py	95.36% ⭐	96.75% ⭐	1.39% 👍
Django_Blog/13-AWS-S3-Uploads/django_project/users/views.py	72.59% 🙂	72.74% 🙂	0.15% 👍
Django_Blog/13-Deployment-Heroku/django_project/blog/views.py	95.36% ⭐	96.75% ⭐	1.39% 👍
Django_Blog/13-Deployment-Heroku/django_project/users/views.py	72.59% 🙂	72.74% 🙂	0.15% 👍
Django_Blog/13-Deployment-Linode/django_project/blog/views.py	95.36% ⭐	96.75% ⭐	1.39% 👍
Django_Blog/13-Deployment-Linode/django_project/users/views.py	72.59% 🙂	72.74% 🙂	0.15% 👍
Ex-Machina/ex-machina.py	85.37% ⭐	85.63% ⭐	0.26% 👍
Generators/mem_profile.py	90.23% ⭐	93.57% ⭐	3.34% 👍
Object-Oriented/3-Class-Static-Methods/oop.py	87.81% ⭐	88.17% ⭐	0.36% 👍
Object-Oriented/4-Inheritance/oop-finish.py	91.66% ⭐	92.27% ⭐	0.61% 👍
Python/Iterators-Coding-Problem/iter-demo.py	96.41% ⭐	96.43% ⭐	0.02% 👍
Python/Matplotlib/09-LiveData/data_gen.py	65.56% 🙂	66.11% 🙂	0.55% 👍
Python/YouTube-API/02-Playlist-Duration/playlist.py	31.70% 😞	33.60% 😞	1.90% 👍
Python/YouTube-API/03-Most-Popular-Video-Playlist/start.py	48.94% 😞	51.26% 🙂	2.32% 👍
Python-Future-Date/credit.py	63.04% 🙂	65.16% 🙂	2.12% 👍
Python-JSON/api.py	82.05% ⭐	82.21% ⭐	0.16% 👍
Python-Random/random_data.py	51.32% 🙂	51.32% 🙂	0.00%
Starting_Code/employee.py	95.27% ⭐	95.29% ⭐	0.02% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

'Refactored by Sourcery'

fc39e4e

sourcery-ai bot requested a review from Ahmed123br January 3, 2022 13:04

sourcery-ai bot commented Jan 3, 2022

View reviewed changes

		@@ -1,4 +1,5 @@
		''' Super simple module to create basic random data for tutorials'''

		messages.success(request, f'Your account has been updated!')
		messages.success(request, 'Your account has been updated!')

Sourcery refactored master branch #1

Are you sure you want to change the base?

Sourcery refactored master branch #1

Uh oh!

Conversation

sourcery-ai bot commented Jan 3, 2022

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 3, 2022