Replace cell Dict with vector-backed CellLookup for neighbor lists#137
Open
AhmedSalih3d wants to merge 6 commits intocodex/optimize-neighborlist-code-performancefrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dictwith contiguous vector-backed lookup arrays to reduce allocations and improve performance and future GPU portability.Description
CellLookup{D}mutable struct and helpers:InitializeCellLookup,ResetCellLookup!,GetCellIndex,SetCellIndex!, and an inlineHashCellIndeximplementation, plus capacity/resize helpers insrc/SPHNeighborList.jl.Dict{CartesianIndex,Int}usage withCellLookupacross neighbor-list code and simulation flow, updating function signatures and call sites insrc/SPHNeighborList.jlandsrc/SPHCellList.jl(e.g.UpdateNeighbors!,BuildNeighborCellLists!, neighbor loops, MDBC handling, andRunSimulationsetup).rg,sed,apply_patch(multiple),git add, andgit commit(used to inspect and modify files and record the change).Testing
Codex Task