Add lip factor to neighbor list cells#158
Open
AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
Open
Add lip factor to neighbor list cells#158AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DefaultNeighborLipFactor = 1.2andNeighborListInverseCutOff(InverseCutOff, LipFactor)tosrc/SPHNeighborList.jlto compute an effective inverse-cutoff for enlarged cells.ExtractCells!to accept aLipFactorand use the effective inverse-cutoff when mapping particle positions into cells, and makeUpdateNeighbors!accept aLipFactorkeyword and forward it toExtractCells!.src/SPHCellList.jlto importDefaultNeighborLipFactorandNeighborListInverseCutOff, apply the lip factor when mapping ghost points to cells, and scale the neighbor-list rebuild threshold andUpdateNeighbors!call by the lip factor.Testing
git add src/SPHNeighborList.jl src/SPHCellList.jlandgit commit -m "Add lip factor to neighbor cells".Codex Task