Add AdvancedMDBC boundary mode with improved ghost-cell corrections#166
Open
AhmedSalih3d wants to merge 15 commits intocodex/refactor-to-avoid-if-statementfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SimpleMDBCpath.Description
AdvancedMDBCsubtype ofMDBCModeand export it fromSimulationMetaDataConfigurationandSPHExampleso it can be selected via theSimulationMetaDatatype parameter.LoadMDBCNormals!overload forAdvancedMDBCinPreProcess.jlto load ghost points and normals just likeSimpleMDBC.ComputeInteractionsMDBCAdvanced!,NeighborLoopMDBCAdvanced!, andApplyMDBCCorrectionAdvancedinsrc/SPHCellList.jlto accumulate per-ghost matrices/vectors, run numerical checks (determinant/condition thresholds), perform matrix solves or fallback density estimates, clone/adjust pressure with hydrostatic correction, and reflect velocities for a no-slip treatment when sufficient kernel coverage exists.ApplyMDBCBeforeHalf!forAdvancedMDBCbefore the full time-step (while leavingSimpleMDBCandNoMDBCbehavior intact) and document the new option inREADME.md.Testing
Codex Task