Add AdvancedMDBC option for dynamic boundary handling#167
Open
AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
Open
Add AdvancedMDBC option for dynamic boundary handling#167AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SimulationMetaDatatype so examples and callers can opt in without breaking existingSimpleMDBCbehaviour.Description
AdvancedMDBCtype and export it alongside existing MDBC modes by extendingSimulationMetaDataConfigurationandSPHExamplewithAdvancedMDBCand the export list (AdvancedMDBC).LoadMDBCNormals!overload forAdvancedMDBCinPreProcess.jlso ghost points and normals are populated from CSV in the same way asSimpleMDBCviaLoadBoundaryNormals.SPHCellList.jlby addingNeighborLoopMDBCAdvanced!,ApplyMDBCBeforeHalf!forAdvancedMDBC, andApplyMDBCCorrectionAdvancedwhich performs numerical checks (kernel sum, matrix determinant/condition), selects a shepherd fallback, computes boundary pressure/density, and applies a no-slip-like velocity correction.LimitDensityAtBoundary!inSimulationEquations.jlto accept anMDBCModeorSimulationMetaDataand skip clamping forAdvancedMDBC, and wire conditional calls to the advanced MDBC apply function in the main time-stepping path inSPHCellList.jl.README.mdto document the newAdvancedMDBC()option and its high-level behaviour.Testing
Codex Task