Skip to content

Fix genesis block to include ALL participating validators (not just 3) #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlanRuno merged 1 commit into from
Jan 19, 2026
Merged

Fix genesis block to include ALL participating validators (not just 3) #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/blockchain/mxd_rsc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2141,11 +2141,12 @@ int mxd_try_coordinate_genesis_block(void) {

qsort(addresses, addr_count, 20, compare_addresses);

// DETERMINISTIC GENESIS: Limit to exactly 3 validators (first 3 sorted addresses)
// This ensures all nodes compute the same validator set
size_t genesis_validator_count = (addr_count < 3) ? addr_count : 3;
// DETERMINISTIC GENESIS: Include ALL participating validators (up to 10)
// This ensures all nodes compute the same validator set and all get initial stake
// Minimum 3 validators required for quorum, maximum 10 for genesis
size_t genesis_validator_count = addr_count;

// Check if this node is in the genesis validator set (first 3 addresses)
// Check if this node is in the genesis validator set (all participating addresses)
int is_genesis_validator = 0;
for (size_t i = 0; i < genesis_validator_count; i++) {
if (memcmp(local_genesis_address, addresses[i], 20) == 0) {
Expand Down Expand Up @@ -2309,7 +2310,9 @@ int mxd_try_coordinate_genesis_block(void) {
current_time = mxd_now_ms(); // Use NTP-synchronized time in milliseconds
}

for (size_t i = 0; i < collected_signature_count && i < 3; i++) {
// Add ALL collected signatures to membership entries (not just first 3)
// This ensures all participating validators are included in the genesis block
for (size_t i = 0; i < collected_signature_count; i++) {
mxd_genesis_signature_t *sig = &collected_signatures[i];

if (mxd_append_membership_entry(&genesis_block, sig->node_address,
Expand All @@ -2321,8 +2324,8 @@ int mxd_try_coordinate_genesis_block(void) {
}

if (!mxd_block_has_membership_quorum(&genesis_block, 0)) {
MXD_LOG_ERROR("rsc", "Genesis block does not have quorum (%u/3 validators)",
genesis_block.rapid_membership_count);
MXD_LOG_ERROR("rsc", "Genesis block does not have quorum (%u/%zu validators)",
genesis_block.rapid_membership_count, collected_signature_count);
genesis_creation_attempted = 0;
return -1;
}
Expand Down
Loading