Fix: Create UTXOs from coinbase transactions during genesis block creation #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where genesis block creation was adding coinbase transactions to the block but not creating the corresponding UTXOs in the UTXO database. This meant validators had no spendable balance after genesis, even though the block showed the correct
total_supply.The fix adds a call to
mxd_create_utxos_from_tx()immediately after creating each coinbase transaction during genesis coordination.Review & Testing Checklist for Human
mxd_try_coordinate_genesis_block()runs, otherwisemxd_create_utxos_from_tx()will fail silently-resetflag and verify that validators actually have 100 MXD spendable balance (check via UTXO lookup, not just metrics display)total_mintedis incremented even when UTXO creation fails (line 2311-2312). Consider whether this could cause inconsistency between reportedtotal_supplyand actual spendable UTXOsRecommended test plan:
./mxd_test_suite test --project mxd-network --nodes 10 --skip-destroyNotes
Link to Devin run: https://app.devin.ai/sessions/dddc2bc4662d4c4a9bc984532b259c36
Requested by: Runo (@AlanRuno)