Add support for generating React components#265
Draft
blackfalcon wants to merge 4 commits intobetafrom
Draft
Conversation
This commit adds new functionality in the Generator script that will create a new file based on icons in the directory that defines new React specific components to allow for better React DX. On branch dsande/reactIcons/264 Changes to be committed: modified: scripts/generate.js
blackfalcon
force-pushed
the
dsande/reactIcons/264
branch
from
d5e574e to
b6c0327
Compare
blackfalcon
changed the title
This commit updates the README to include the following: 1. Remove legacy unsupported processes 2. Update to include new recommendations On branch dsande/reactIcons/264 Changes to be committed: modified: README.md
This commit enhances the baseline react component support by providing Typescript declarations for all icons within the repo. On branch dsande/reactIcons/264 Your branch is up to date with 'origin/dsande/reactIcons/264'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Resolves: #264
Summary:
This PR adds new functionality in the Generator script that will create a new file based on icons in the directory that defines new React specific components to allow for better React DX.
Type of change:
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team