Skip to content

Comments

Create Icon Font for iOS and Android#289

Draft
kaitlynch1 wants to merge 3 commits intoAlaskaAirlines:masterfrom
kaitlynch1:kaitlynch1/iconfont
Draft

Create Icon Font for iOS and Android#289
kaitlynch1 wants to merge 3 commits intoAlaskaAirlines:masterfrom
kaitlynch1:kaitlynch1/iconfont

Conversation

@kaitlynch1
Copy link

Alaska Airlines Pull Request

Resolves: #285

Summary:

This PR creates an Icon font (generated by fontcustom) to leverage in iOS and Android apps. This font will replace the cumbersome process in iOS + Android apps today of shipping multiple sizes (1x, 2x, 3x) of icon PNGs. The font will allow automatic scaling with accessibility, and re-color on theme changes.

This change also includes adding a viewBox attribute to each svg's root tag in the /icons folder (not subdirectories), which was necessary to import into a font.

Type of change:

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants