Create Icon Font for iOS and Android#289
Draft
kaitlynch1 wants to merge 3 commits intoAlaskaAirlines:masterfrom
Draft
Create Icon Font for iOS and Android#289kaitlynch1 wants to merge 3 commits intoAlaskaAirlines:masterfrom
kaitlynch1 wants to merge 3 commits intoAlaskaAirlines:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Resolves: #285
Summary:
This PR creates an Icon font (generated by fontcustom) to leverage in iOS and Android apps. This font will replace the cumbersome process in iOS + Android apps today of shipping multiple sizes (1x, 2x, 3x) of icon PNGs. The font will allow automatic scaling with accessibility, and re-color on theme changes.
This change also includes adding a viewBox attribute to each svg's root tag in the /icons folder (not subdirectories), which was necessary to import into a font.
Type of change:
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team