Skip to content

Comments

feat: update CSSCustomProperties paths with auro-classic theme#593

Merged
chrisfalaska merged 2 commits intomasterfrom
cfriedberg/592
Feb 26, 2025
Merged

feat: update CSSCustomProperties paths with auro-classic theme#593
chrisfalaska merged 2 commits intomasterfrom
cfriedberg/592

Conversation

@chrisfalaska
Copy link
Contributor

@chrisfalaska chrisfalaska commented Feb 26, 2025

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves:

AlaskaAirlines/AuroDesignTokens#212
#592

Summary:

Updates CSSCustomProperties path with new auro-classic filepath in support of Design Tokens v5 update.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Update CSSCustomProperties paths to align with the Design Tokens v5 update and the new auro-classic filepath.

@chrisfalaska chrisfalaska requested a review from a team as a code owner February 26, 2025 18:50
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 26, 2025

Reviewer's Guide by Sourcery

This pull request updates the CSSCustomProperties path to align with the Design Tokens v5 update, specifically pointing to the new auro-classic file path. This change impacts the component documentation and demo templates.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the CSSCustomProperties path to reflect the new auro-classic file path.
  • Updated the CSSCustomProperties path in bundleUse.md.
  • Updated the CSSCustomProperties path in bundleUseModBrowsers.md.
  • Updated the CSSCustomProperties path in api.html.
  • Updated the CSSCustomProperties path in index.html.
componentDocs/partials/usage/bundleUse.md
componentDocs/partials/usage/bundleUseModBrowsers.md
template/demo/api.html
template/demo/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@chrisfalaska chrisfalaska linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisfalaska - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It looks like you're updating the path for CSS custom properties; can you confirm that the older path is no longer valid?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chrisfalaska chrisfalaska merged commit cc1ec60 into master Feb 26, 2025
6 checks passed
@chrisfalaska chrisfalaska deleted the cfriedberg/592 branch February 26, 2025 20:38
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Completed work has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CSSCustomProperties path to reference Auro Classic Theme

3 participants