feat: update CSSCustomProperties paths with auro-classic theme#593
Merged
chrisfalaska merged 2 commits intomasterfrom Feb 26, 2025
Merged
feat: update CSSCustomProperties paths with auro-classic theme#593chrisfalaska merged 2 commits intomasterfrom
chrisfalaska merged 2 commits intomasterfrom
Conversation
Reviewer's Guide by SourceryThis pull request updates the CSSCustomProperties path to align with the Design Tokens v5 update, specifically pointing to the new No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @chrisfalaska - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're updating the path for CSS custom properties; can you confirm that the older path is no longer valid?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ff81d4f to
70b7f65
Compare
jason-capsule42
approved these changes
Feb 26, 2025
Member
|
🎉 This PR is included in version 4.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves:
AlaskaAirlines/AuroDesignTokens#212
#592
Summary:
Updates
CSSCustomPropertiespath with newauro-classicfilepath in support of Design Tokensv5update.Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Update CSSCustomProperties paths to align with the Design Tokens v5 update and the new
auro-classicfilepath.