Merged
Conversation
Previously, the undo stack only stored the "commands" that were applied to update the state. This is memory efficient, but has become difficult to reason about. This new approach simply stores the entire state of the application before and after each action is taken. This will use a lot more memory, but this should be possible to optimise later if it turns out to be a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on refactoring the application to be less dependent on the grid representation of inputs, I ran into trouble getting the undo stack working. This change should make the refactor easier.
Previously, the undo stack only stored the "commands" that were applied to update the state. This is memory efficient, but has become difficult to reason about. This new approach simply stores the entire state of the application before and after each action is taken. This will use a lot more memory, but this should be possible to optimise later if it turns out to be a problem.