-
Notifications
You must be signed in to change notification settings - Fork 4
Minor update for the path and the title of extension #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @AlexSheer, could you merge this, please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An extension can't be renamed as easily as that you do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu proposes quoi en lieu et place ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Galixte: English on GitHub :)
Renaming an extension need to update the namespace in PHP files. But this action are also side effects: To change the name, we need to purge the extension, resulting in loss of datas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can pre-make a backup copy of the table of this extension and then use these data for new renamed extension.
|
Hi @AlexSheer, could you take a look about this: #4 (comment). |
|
This will require to replace word "knowlegebase" in every file extension, where it occurs. |
|
Do you want that i update all necessary changes in all files ? (I can do that) |
|
Yes of course if you want :) |
|
In additition i think, the author name should be "sheer" not "Sheer" with leading great "s". Are you still working on this? @Galixte @AlexSheer |
|
Hi, @Crizz0 not yet. ;) |
|
i work on a translation into german, if you like, include it please. |
|
Hi @scenicforum, it could be better if you submit a new Pull request. ;) |
No description provided.