Skip to content

Add Docker #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
AlexWayfer wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add Docker #12

AlexWayfer wants to merge 2 commits into from
+84 −1

Conversation

@AlexWayfer
Copy link
Owner

@AlexWayfer AlexWayfer commented Sep 29, 2020 •
edited
Loading

Resolve #13

@AlexWayfer AlexWayfer added enhancement New feature or request questionable We're not sure that this need to be done labels Sep 29, 2020
@AlexWayfer AlexWayfer self-assigned this Sep 29, 2020
@AlexWayfer AlexWayfer force-pushed the add_docker branch 2 times, most recently from 5f9014e to ae740d8 Compare October 1, 2020 10:55
@AlexWayfer
Copy link
Owner Author

AlexWayfer commented Oct 1, 2020

We (already or can) have problems with:

  • Database creation
    • Is toys db create possible at all? If not — we should use correct (sync) user, password, PSQL extensions.
  • toys config check
    • It has no problems now if there are already configs, but it will have problems for fresh initialized project and after config examples update. Probably we should move it inside toys server start command.
  • toys server start output
    • Right now this command fails due to DB errors, but we should handle output later.
    • There is somewhy pumactl restart after the first start, even after docker-compose down.
  • binding.pry

Right now I'm leaving this PR staling, because I have no with to dig into this deeper. rbenv and nodenv have to be installed and allow to manage versions between projects, and if you want to use specific version of PostgreSQL — you can use a Docker image with it, expose port and connect to it from the application.

@AlexWayfer
Switch Docker from Debian to ArchLinux, used in CI
8f08dff 
Also there are less dependencies.
@AlexWayfer AlexWayfer mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AlexWayfer AlexWayfer

Labels

enhancement New feature or request questionable We're not sure that this need to be done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Docker

2 participants

@AlexWayfer