Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apricot/apricot.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package apricot implements the ALICE configuration service with templating,
// load balancing and caching capabilities on top of the configuration store.
package apricot

import (
Expand Down
2 changes: 2 additions & 0 deletions apricot/cacheproxy/service.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Package cacheproxy provides a caching proxy implementation for the
// configuration service, optimizing detector inventory lookups.
package cacheproxy

import (
Expand Down
2 changes: 2 additions & 0 deletions apricot/local/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package local implements a local filesystem backend for the configuration
// service, providing file-based configuration storage and retrieval.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessarily file-based, different cfgbackends can be used, yaml is only one of them. The locality here means that here we have direct access to the backend, while remote/service.go has gRPC in between. I could be wrong though, so verify my words.

Rewrite the package description accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the description to clarify that "local" means direct access to the backend (not necessarily file-based) while "remote" has gRPC in between. Changed to: "Package local implements a local configuration backend for the configuration service, providing direct access to the backend storage without gRPC." (7bfb4cc)

package local

import (
Expand Down
2 changes: 2 additions & 0 deletions apricot/remote/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package remote implements a remote gRPC client backend for the configuration
// service, providing access to remote configuration stores.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Remote" meaning basically that is handled by a different application. Please clarify this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified that "remote" means handled by a different application. Updated to: "Package remote implements a remote configuration backend for the configuration service, accessing configuration handled by a different application via gRPC." (7bfb4cc)

package remote

import (
Expand Down
2 changes: 2 additions & 0 deletions coconut/app/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package app provides application constants and metadata for the coconut
// command line interface and its components.
package app

const (
Expand Down
2 changes: 2 additions & 0 deletions coconut/cmd/environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

//go:generate protoc -I=../../core -I=../../common --go_out=.. --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative --go-grpc_out=require_unimplemented_servers=false:.. protos/o2control.proto

// Package cmd implements the command line interface for coconut, providing
// various subcommands for managing O² Control environments and configurations.
package cmd

import (
Expand Down
2 changes: 2 additions & 0 deletions common/event/topic/topic.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package topic defines topic constants and types for the event system,
// providing structured topic names for different event types.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Masło maślane. Shorten it to avoid repetition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortened to avoid repetition: "Package topic defines constants and types for event system topics." (7bfb4cc)

package topic

type Topic string
Expand Down
2 changes: 2 additions & 0 deletions common/event/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package event provides event publishing and streaming functionality for
// O² Control components, supporting both Kafka and in-memory event systems.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to the in-memory event system you mentioned here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - the "in-memory event system" was inaccurate. The DummyWriter is actually a no-op writer, not a true in-memory system. Updated to: "Package event provides event publishing and streaming functionality for O² Control components, supporting Kafka and dummy event writers." (7bfb4cc)

package event

import (
Expand Down
2 changes: 2 additions & 0 deletions common/golangmetrics/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package golangmetrics provides Go runtime metrics collection and reporting
// functionality for monitoring system resource usage and performance.
package golangmetrics

import (
Expand Down
2 changes: 2 additions & 0 deletions common/logger/infologger/protocols.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package infologger provides InfoLogger protocol implementation for
// integration with the ALICE InfoLogger logging system.
package infologger

type protoVersion string
Expand Down
2 changes: 2 additions & 0 deletions common/monitoring/monitoring.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package monitoring provides monitoring and metrics collection functionality,
// including HTTP endpoints for health checks and metrics publishing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to the health check endpoint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct - there are no HTTP health check endpoints in this package (the health endpoints are gRPC-based in core/server.go). Simplified the description to: "Package monitoring provides monitoring and metrics collection functionality for O² Control components." (7bfb4cc)

package monitoring

import (
Expand Down
2 changes: 2 additions & 0 deletions common/product/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package product provides version information and build metadata for
// O² Control products and components.
package product

import (
Expand Down
2 changes: 2 additions & 0 deletions common/utils/safeacks/safeacks.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package safeacks provides thread-safe acknowledgment handling for managing
// communication between multiple senders and a single receiver.
package safeacks

import (
Expand Down
2 changes: 2 additions & 0 deletions common/utils/uid/uid.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package uid provides unique identifier generation functionality,
// including machine-specific and time-based ID generation utilities.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Package uid provides unique identifier generation functionality,
// including machine-specific and time-based ID generation utilities.
// Package uid provides unique identifier generation functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified as suggested: "Package uid provides unique identifier generation functionality." (7bfb4cc)

package uid

import (
Expand Down
2 changes: 2 additions & 0 deletions common/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package utils provides common utility functions for string manipulation,
// data conversion, and various helper operations used across O² Control components.
package utils

import (
Expand Down
2 changes: 2 additions & 0 deletions configuration/componentcfg/componentcfg.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package componentcfg provides component configuration management functionality,
// including query handling and template processing for O² components.
package componentcfg

import (
Expand Down
2 changes: 2 additions & 0 deletions configuration/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package configuration provides interfaces and implementations for managing
// runtime configuration of O² Control components and detectors.
package configuration

import (
Expand Down
2 changes: 2 additions & 0 deletions configuration/template/fields.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package template provides template processing functionality for configuration
// files, including custom field handling and template execution.
package template

import (
Expand Down
2 changes: 2 additions & 0 deletions core/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package core implements the main AliECS core functionality including
// the gRPC API server, environment management, and integration with various services.
package core
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add the package description here instead of core/core.go? Whenever there is a source file with the same name as the package name, please add the package description there. Review all the changes in this regards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the package description from config.go to core.go since core.go has the same name as the package. Also reviewed and moved package documentation for all integration packages to their respective plugin.go files. (7bfb4cc)


import (
Expand Down
2 changes: 2 additions & 0 deletions core/integration/bookkeeping/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package bookkeeping provides integration with the ALICE Bookkeeping system
// for tracking runs and retrieving LHC fill information.
package bookkeeping
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for plugin packages, put the package descriptions in plugin.go files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved package descriptions to plugin.go files for all integration packages: bookkeeping, dcs, odc, ddsched, and trg. (7bfb4cc)


import (
Expand Down
2 changes: 2 additions & 0 deletions core/integration/ccdb/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package ccdb provides integration with the Condition and Calibration Database (CCDB)
// for creating and managing General Run Parameters (GRP) objects.
package ccdb

import (
Expand Down
2 changes: 2 additions & 0 deletions core/integration/dcs/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package dcs provides integration with the ALICE Detector Control System (DCS)
// for managing detector operations and state compatibility checks.
package dcs

import (
Expand Down
2 changes: 2 additions & 0 deletions core/integration/ddsched/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package ddsched provides integration with the Data Distribution (DD) scheduler
// for managing the pool of FLPs participating in data taking operations.
package ddsched

import (
Expand Down
2 changes: 2 additions & 0 deletions core/integration/odc/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package odc provides integration with the Online Device Control (ODC) system
// for managing the ALICE event processing farm during data taking and offline processing.
package odc

import (
Expand Down
2 changes: 2 additions & 0 deletions core/integration/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package integration provides the plugin system for integrating O² Control
// with external services like DCS, Bookkeeping, ODC, and other ALICE systems.
package integration

import (
Expand Down
2 changes: 2 additions & 0 deletions core/integration/testplugin/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package testplugin provides a test integration plugin that serves as an example
// and is used for testing the plugin system functionality.
package testplugin

import (
Expand Down
2 changes: 2 additions & 0 deletions core/integration/trg/trgutil.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package trg provides integration with the ALICE trigger system
// for managing trigger configurations and run coordination.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Package trg provides integration with the ALICE trigger system
// for managing trigger configurations and run coordination.
// Package trg provides integration with the ALICE trigger system.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified as suggested: "Package trg provides integration with the ALICE trigger system." (7bfb4cc)

package trg

import (
Expand Down
2 changes: 2 additions & 0 deletions core/repos/sshrepo.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package repos provides repository management functionality for accessing
// and synchronizing Git repositories containing workflow templates and configurations.
package repos

import (
Expand Down
2 changes: 2 additions & 0 deletions core/repos/varsource/varsource.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package varsource provides variable source management functionality for
// tracking the origin and precedence of configuration variables in workflows.
package varsource

type Source int
Expand Down
2 changes: 2 additions & 0 deletions core/task/channel/inbound.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package channel provides functionality for managing task communication channels,
// including inbound and outbound channel configuration and message routing.
package channel

import (
Expand Down
2 changes: 2 additions & 0 deletions core/task/schedutil/mesosutil.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package schedutil provides scheduler utility functions for Apache Mesos
// integration, including resource management and task scheduling helpers.
package schedutil

import (
Expand Down
2 changes: 2 additions & 0 deletions core/task/sm/machine.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package sm provides state machine functionality for task lifecycle management,
// including state transitions and event handling.
package sm

type Transition struct {
Expand Down
2 changes: 2 additions & 0 deletions core/task/taskclass/port/range.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package port provides port range management functionality for task
// communication, including port range parsing and validation.
package port

import (
Expand Down
2 changes: 2 additions & 0 deletions core/task/taskclass/resourcelimits.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package taskclass provides task class definitions and resource management
// for different types of tasks in the O² Control system.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Package taskclass provides task class definitions and resource management
// for different types of tasks in the O² Control system.
// Package taskclass provides task class definitions and resource management
// for different types of tasks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested: "Package taskclass provides task class definitions and resource management for different types of tasks." (7bfb4cc)

package taskclass

import "strconv"
Expand Down
2 changes: 2 additions & 0 deletions core/task/taskop/messagetype.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package taskop provides task operation types and message handling functionality
// for controlling task lifecycle and communication.
package taskop

import (
Expand Down
2 changes: 2 additions & 0 deletions core/the/eventwriter.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package the provides global event handling and state management for
// the core system, including event writers and system-wide notifications.
package the

import (
Expand Down
2 changes: 2 additions & 0 deletions core/workflow/callable/utils.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Package callable provides utility functions for workflow callable operations,
// including timeout handling and trigger expression parsing.
package callable

import (
Expand Down
2 changes: 2 additions & 0 deletions executor/executable/task_pdeathsig_darwin.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package executable provides platform-specific executable management functionality
// for running and controlling tasks in the executor environment.
package executable

import "syscall"
Expand Down
2 changes: 2 additions & 0 deletions executor/executorcmd/nopb/jsoncodec.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package nopb provides non-protobuf encoding functionality including
// JSON codec implementations for gRPC communication.
package nopb

import (
Expand Down
2 changes: 2 additions & 0 deletions executor/executorcmd/transitioner/direct.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package transitioner provides transition management functionality for
// handling task state transitions with different transition strategies.
package transitioner

type Direct struct {
Expand Down
2 changes: 2 additions & 0 deletions executor/executorutil/executorutil.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package executorutil provides utility functions for the executor,
// including resource management and task execution helpers.
package executorutil

import (
Expand Down
2 changes: 2 additions & 0 deletions occ/peanut/peanut.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Intergovernmental Organization or submit itself to any jurisdiction.
*/

// Package peanut implements a process execution and control utility for
// OCClib-based O² processes, providing debugging and development support.
package peanut

import (
Expand Down
Loading