Skip to content

Conversation

@dsekihat
Copy link
Collaborator

PWGEM/Dilepton: update trigger analyses

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

O2 linter results: ❌ 408 errors, ⚠️ 621 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title PWGEM/Dilepton: update trigger analyses [PWGEM/Dilepton] update trigger analyses Dec 11, 2025
@dsekihat dsekihat marked this pull request as draft December 12, 2025 10:24
@dsekihat dsekihat marked this pull request as ready for review December 19, 2025 11:38
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for d7185e3 at 2025-12-19 13:12:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:230:114: error: unused parameter 'emswtinfostmp' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:230:166: error: unused parameter 'emswtATcounterstmp' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:230:224: error: unused parameter 'emswtTOIcounterstmp' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:253:124: error: unused parameter 'emswtinfostmp' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:253:176: error: unused parameter 'emswtATcounterstmp' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:253:234: error: unused parameter 'emswtTOIcounterstmp' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:276:134: error: unused parameter 'emswtinfostmp' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:276:186: error: unused parameter 'emswtATcounterstmp' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/14168-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:276:244: error: unused parameter 'emswtTOIcounterstmp' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@rbailhac
Copy link
Collaborator

Hi @dsekihat , I think you started to correct some of my comments below but here are there:

skimmerOTS.cxx
/////////////////

Produceso2::aod::EMSWTriggerInfosTMP swtinfo_tmp; // Join aod::Collision later.
--> Do we still need this table, which are just the info from the CCDB that we can read again during the analysis ??

Produceso2::aod::EMSWTriggerATCountersTMP swtcounterAT_tmp;
Produceso2::aod::EMSWTriggerTOICountersTMP swtcounterTOI_tmp;
--> Do we still need this tables ?? They are not used anymore or ?

createEMEventDilepton.cxx
////////////////////////////

void processEvent_SWT_Cent_Qvec(MyCollisionsWithSWT_Cent_Qvec const& collisions, MyBCs const& bcs, aod::EMSWTriggerInfosTMP const& emswtinfostmp, aod::EMSWTriggerATCountersTMP const& emswtATcounterstmp, aod::EMSWTriggerTOICountersTMP const& emswtTOIcounterstmp)
--> Do we need on this tables in the function ?? Only aod::EMSWTriggerInfosTMP should be enough or ?
Same remark for the version without Qvec....

General question just to be sure:
By calling the function Zorro.isSelected (either during the production of the derived data or during the analysis)
, I do not see that you pass a TH2* histogram to write the information. Do we nevertheless have the information (mAnalysedTriggersOfInterest and mAnalysedTriggers) in the output for both the production of the derived data and the analysis ?

@dsekihat
Copy link
Collaborator Author

dsekihat commented Dec 19, 2025

Dear @rbailhac , I removed unnecessary lines.
General question just to be sure: By calling the function Zorro.isSelected (either during the production of the derived data or during the analysis) , I do not see that you pass a TH2* histogram to write the information. Do we nevertheless have the information (mAnalysedTriggersOfInterest and mAnalysedTriggers) in the output for both the production of the derived data and the analysis ? -> Yes, populateHistRegistry does the job.

Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat merged commit 47452ef into AliceO2Group:master Dec 20, 2025
11 of 12 checks passed
@dsekihat dsekihat deleted the emswt branch December 20, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants