Skip to content

Conversation

@nburmaso
Copy link
Contributor

@nburmaso nburmaso commented Dec 19, 2025

  • Adding simplified task for forward muon analysis in UPCs (w.r.t. UPCCandidateProducer)
  • fwdTrackPropagation.cxx -- propagate only tracks with MFT to attached collision vertex
  • Fix typo in pDCA selection for forward tracks in UPCHelpers.h

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

O2 linter results: ❌ 1 errors, ⚠️ 11 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add separate task for forward muon analysis [PWGUD] Add separate task for forward muon analysis Dec 19, 2025
@rolavick
Copy link
Collaborator

Thanks Nazar, it looks good. May I ask you to address selected o2linter issues, namely the following? Should not be much work. Thanks.

(performance reasons)
PWGUD/TableProducer/fwdTrackPropagation.cxx:149: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity]
PWGUD/TableProducer/fwdTrackPropagation.cxx:150: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity]
PWGUD/TableProducer/fwdTrackPropagation.cxx:151: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity]
PWGUD/TableProducer/fwdTrackPropagation.cxx:152: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity]
PWGUD/TableProducer/fwdTrackPropagation.cxx:153: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity]
PWGUD/TableProducer/fwdTrackPropagation.cxx:93: warning: Use lowerCamelCase for names of functions and variables. [name/function-variable]

PWGUD/TableProducer/upcCandProducerMuon.cxx:15: warning: Documentation for \file is missing, incorrect or misplaced. [doc/file] (I guess the name of file should be lower case)

@nburmaso
Copy link
Contributor Author

Thanks Nazar, it looks good. May I ask you to address selected o2linter issues, namely the following? Should not be much work. Thanks.

(performance reasons) PWGUD/TableProducer/fwdTrackPropagation.cxx:149: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity] PWGUD/TableProducer/fwdTrackPropagation.cxx:150: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity] PWGUD/TableProducer/fwdTrackPropagation.cxx:151: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity] PWGUD/TableProducer/fwdTrackPropagation.cxx:152: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity] PWGUD/TableProducer/fwdTrackPropagation.cxx:153: warning: Replace ROOT entities with equivalents from standard C++ or from O2. [root/entity] PWGUD/TableProducer/fwdTrackPropagation.cxx:93: warning: Use lowerCamelCase for names of functions and variables. [name/function-variable]

PWGUD/TableProducer/upcCandProducerMuon.cxx:15: warning: Documentation for \file is missing, incorrect or misplaced. [doc/file] (I guess the name of file should be lower case)

Hi @rolavick,

I have fixed the linter warnings.

Cheers,
Nazar

@rolavick rolavick enabled auto-merge (squash) December 19, 2025 16:59
@rolavick rolavick merged commit 00dda3a into AliceO2Group:master Dec 19, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants