[QC-1206] Make database available to user code + refactor *Config to extract common part #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
approved these changes
Oct 30, 2024
Collaborator
|
@knopers8 @Barthelemy is there a reason why this wasn't merge yet? |
Collaborator
Author
|
@justonedev1 I think that we just forgot. Damn. I have to fix it now. I'll fix the merge issues. |
…ctor *Config to extract common part - needed for the CTP Scalers - it required adding the database param to all the *Config.h I decided to extract the common part to a new interface `UserCodeConfig`. # Conflicts: # Framework/src/PostProcessingConfig.cxx
Barthelemy
force-pushed
the
add-database-userinterface
branch
from
8581b15 to
08d748c
Compare
Collaborator
Author
|
Ok, I fixed the merge. |
knopers8
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserCodeConfig.DO NOT MERGE BEFORE HI