[QC-985]: Configurable Reductors #2517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- field reductorParameters inside of dataSources is used - internally we use CustomParameters so json config has same format as extendedTaskParameters
knopers8
approved these changes
Mar 6, 2025
| #include "QualityControl/ConditionAccess.h" | ||
| #include <TH1I.h> | ||
| #include <TTree.h> | ||
| #include <boost/test/tools/old/interface.hpp> |
Collaborator
There was a problem hiding this comment.
unwanted header added automatically?
Comment on lines
+55
to
+73
| // https://stackoverflow.com/questions/424104/can-i-access-private-members-from-outside-the-class-without-using-friends | ||
| template <typename Accessor, typename Accessor::type Member> | ||
| struct DeclareGlobalGet { | ||
| friend typename Accessor::type get(Accessor) { return Member; } | ||
| }; | ||
|
|
||
| struct TrendingTaskReductorAccessor { | ||
| using type = std::unordered_map<std::string, std::unique_ptr<Reductor>> TrendingTask::*; | ||
| friend type get(TrendingTaskReductorAccessor); | ||
| }; | ||
|
|
||
| struct ReductorConfigAccessor { | ||
| using type = CustomParameters Reductor::*; | ||
| friend type get(ReductorConfigAccessor); | ||
| }; | ||
|
|
||
| template struct DeclareGlobalGet<TrendingTaskReductorAccessor, &TrendingTask::mReductors>; | ||
| template struct DeclareGlobalGet<ReductorConfigAccessor, &Reductor::mCustomParameters>; | ||
|
|
Collaborator
There was a problem hiding this comment.
I have to admit, I spent 2 hours trying to understand it and I did not manage. Not saying that the solution is bad though, but I need some learning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Framework] classes inherited from Reductor are now configurable