QC-1161 remove unused code for quality flag support #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
approved these changes
Mar 17, 2025
Collaborator
justonedev1
left a comment
justonedev1
left a comment
There was a problem hiding this comment.
It looks ok, but why don't we need this code? Is it because we are using kafka to propagating the flags?
Collaborator
Author
Not even Kafka, but a gRPC call to BKP that you added. A few years ago we assumed we would keep the flags in QCDB, but we switched to BKP. |
Collaborator
|
Ah right... that is what I meant. Thanks |
Barthelemy
approved these changes
Mar 17, 2025
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
I love seeing code being removed. Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.