Skip to content

Conversation

@afurs
Copy link
Collaborator

@afurs afurs commented Mar 19, 2025

  1. Temporary entity AmpTimeDistribution is added into QC until it is not implemented into O2 DataFormatsFIT with FT0 calibration patch.
  2. Binning along x-axis is changed in amp-time hist 1000->315 and 100->200 for y-axis. Total size decrease is 1.5
  3. Coll BC selection is added for amp-time, askGRPLHCIF option is needed for cfg. Also added min bias trigger parametrization based on system type.

@afurs afurs requested a review from andreasmolander as a code owner March 19, 2025 13:59
@afurs
Copy link
Collaborator Author

afurs commented Mar 19, 2025

Hello @Barthelemy I would like to have this patch in the next apass2 PbPb 2024 production. Is there anything which should be done from my side?

@Barthelemy
Copy link
Collaborator

Hello @Barthelemy I would like to have this patch in the next apass2 PbPb 2024 production. Is there anything which should be done from my side?

I don't remember to be honest. @chiarazampolli or @JianLIUhep probably know.

@JianLIUhep
Copy link
Contributor

JianLIUhep commented Mar 21, 2025

Hi @afurs, is the PR in O2DPG related to this? If so, please add the needed labels in the O2DPG PR, and also mention that the DPG PR needs this QC PR to be included in 2024 Pb-Pb apass2.

@afurs
Copy link
Collaborator Author

afurs commented Mar 21, 2025

Hi @afurs, is the PR in O2DPG related to this? If so, please add the needed labels in the O2DPG PR, and also mention that the DPG PR needs this QC PR to be included in 2024 Pb-Pb apass2.

Hi @JianLIUhep yes! I'm sorry, I forgot to link that PR to this. I will do that asap.

@afurs
Copy link
Collaborator Author

afurs commented Mar 21, 2025

@JianLIUhep I'm doing this procedure first time, could you please check? I mentioned this PR in AliceO2Group/O2DPG#1945 and corresponding label is added to that PR.

@alcaliva alcaliva enabled auto-merge (squash) March 21, 2025 09:56
@alcaliva alcaliva self-assigned this Mar 21, 2025
@afurs
Copy link
Collaborator Author

afurs commented Mar 26, 2025

Hello @Barthelemy @JianLIUhep , could you please merged it?

@Barthelemy Barthelemy disabled auto-merge March 26, 2025 15:21
@Barthelemy
Copy link
Collaborator

We would need @andreasmolander review to merge it the standard way.
I am going to force merge now.

@Barthelemy Barthelemy merged commit a8d3833 into AliceO2Group:master Mar 26, 2025
6 checks passed
@afurs
Copy link
Collaborator Author

afurs commented Mar 26, 2025

@Barthelemy well, @andreasmolander had a week to review + my expertise should be enough (just check number of commits I made for QC FIT module in total) :)

@knopers8
Copy link
Collaborator

Then we will not accept any patch requests for this release ;)

@afurs
Copy link
Collaborator Author

afurs commented Mar 27, 2025

Then we will not accept any patch requests for this release ;)

okay, I got your point ;) but exactly this patch is strongly needed for PbPb 2024 apass2, otherwise FT0 slewing quality will be hard to check. And it took a week for merging trivial patch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants