-
Notifications
You must be signed in to change notification settings - Fork 158
RecoQC FT0: changed amp-time hist #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @Barthelemy I would like to have this patch in the next apass2 PbPb 2024 production. Is there anything which should be done from my side? |
I don't remember to be honest. @chiarazampolli or @JianLIUhep probably know. |
|
Hi @afurs, is the PR in O2DPG related to this? If so, please add the needed labels in the O2DPG PR, and also mention that the DPG PR needs this QC PR to be included in 2024 Pb-Pb apass2. |
Hi @JianLIUhep yes! I'm sorry, I forgot to link that PR to this. I will do that asap. |
|
@JianLIUhep I'm doing this procedure first time, could you please check? I mentioned this PR in AliceO2Group/O2DPG#1945 and corresponding label is added to that PR. |
|
Hello @Barthelemy @JianLIUhep , could you please merged it? |
|
We would need @andreasmolander review to merge it the standard way. |
|
@Barthelemy well, @andreasmolander had a week to review + my expertise should be enough (just check number of commits I made for QC FIT module in total) :) |
|
Then we will not accept any patch requests for this release ;) |
okay, I got your point ;) but exactly this patch is strongly needed for PbPb 2024 apass2, otherwise FT0 slewing quality will be hard to check. And it took a week for merging trivial patch... |
AmpTimeDistributionis added into QC until it is not implemented into O2 DataFormatsFIT with FT0 calibration patch.