CTP: Input alinement check #2526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks ok to me, please, remove draft. |
lhusova
requested review from
Barthelemy,
justonedev1 and
knopers8
as code owners
Barthelemy
requested changes
Mar 24, 2025
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
thank you for your PR. Please see and address my comments.
regards,
| msg->SetTextSize(0.03); | ||
| msg->SetNDC(); | ||
| h->GetListOfFunctions()->Add(msg->Clone()); | ||
| initialMessagePos -= 0.04; |
Collaborator
There was a problem hiding this comment.
the same piece of code is repeated again and again. Please extract it in a method.
| h->GetListOfFunctions()->Add(msg->Clone()); | ||
| initialMessagePos -= 0.04; | ||
| } | ||
| if (h->GetBinContent(3) > 0) { |
Collaborator
There was a problem hiding this comment.
this series of if can probably be replaced by a loop but that's up to you.
| h->SetStats(kFALSE); | ||
| h->GetYaxis()->SetRangeUser(0, h->GetMaximum() * 1.5); | ||
| } else if (mo->getName() == "decodeError") { | ||
| auto* h = dynamic_cast<TH1D*>(mo->getObject()); |
Collaborator
There was a problem hiding this comment.
h can be null. Please check for it and return if needed.
Modules/CTP/src/qc-ctp.json
Outdated
| }, | ||
| "conditionDB": { | ||
| "url": "ccdb-test.cern.ch:8080" | ||
| "url": "alice-ccdb.cern.ch" |
Collaborator
There was a problem hiding this comment.
as these files are used for test, I wouldn't advise pointing to production.
Barthelemy
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lietava please check the changes