Skip to content

MCH: make LastCycle and trending plots optional #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 1 commit into from
Apr 10, 2025
Merged

MCH: make LastCycle and trending plots optional #2532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Modules/MUON/MCH/include/MCH/DecodingPostProcessing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ class DecodingPostProcessing : public PostProcessingInterface
static std::string syncStatusSourceName() { return "syncstatus"; }

bool mFullHistos{ false };
bool mEnableLastCycleHistos{ false };
bool mEnableTrending{ false };

PostProcessingConfigMCH mConfig;

Expand Down
4 changes: 3 additions & 1 deletion Modules/MUON/MCH/include/MCH/DigitsPostProcessing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ class DigitsPostProcessing : public PostProcessingInterface
static std::string orbitsSourceName() { return "orbits"; }
static std::string orbitsSignalSourceName() { return "orbits_signal"; }

int64_t mRefTimeStamp{ 0 };
bool mFullHistos{ false };
bool mEnableLastCycleHistos{ false };
bool mEnableTrending{ false };

float mChannelRateMin{ 0 };
float mChannelRateMax{ 100 };

Expand Down
2 changes: 2 additions & 0 deletions Modules/MUON/MCH/include/MCH/PreclustersPostProcessing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ class PreclustersPostProcessing : public PostProcessingInterface
static std::string clusterSizeSourceName() { return "clsize"; }

bool mFullHistos{ false };
bool mEnableLastCycleHistos{ false };
bool mEnableTrending{ false };

PostProcessingConfigMCH mConfig;

Expand Down
101 changes: 53 additions & 48 deletions Modules/MUON/MCH/src/DecodingPostProcessing.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,6 @@ void DecodingPostProcessing::configure(const boost::property_tree::ptree& config

void DecodingPostProcessing::createDecodingErrorsHistos(Trigger t, repository::DatabaseInterface* qcdb)
{
//------------------------------------------
// Helpers to extract plots from last cycle
//------------------------------------------

auto obj = mCcdbObjects.find(errorsSourceName());
if (obj != mCcdbObjects.end()) {
mErrorsOnCycle.reset();
mErrorsOnCycle = std::make_unique<HistoOnCycle<TH2FRatio>>();
}

//----------------------------------
// Decoding errors plotters
//----------------------------------
Expand All @@ -58,25 +48,24 @@ void DecodingPostProcessing::createDecodingErrorsHistos(Trigger t, repository::D
mErrorsPlotter = std::make_unique<DecodingErrorsPlotter>("DecodingErrors/");
mErrorsPlotter->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);

mErrorsPlotterOnCycle.reset();
mErrorsPlotterOnCycle = std::make_unique<DecodingErrorsPlotter>("DecodingErrors/LastCycle/");
mErrorsPlotterOnCycle->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);
if (mEnableLastCycleHistos) {
// Helpers to extract plots from last cycle
auto obj = mCcdbObjects.find(errorsSourceName());
if (obj != mCcdbObjects.end()) {
mErrorsOnCycle.reset();
mErrorsOnCycle = std::make_unique<HistoOnCycle<TH2FRatio>>();
}

mErrorsPlotterOnCycle.reset();
mErrorsPlotterOnCycle = std::make_unique<DecodingErrorsPlotter>("DecodingErrors/LastCycle/");
mErrorsPlotterOnCycle->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);
}
}

//_________________________________________________________________________________________

void DecodingPostProcessing::createHeartBeatPacketsHistos(Trigger t, repository::DatabaseInterface* qcdb)
{
//------------------------------------------
// Helpers to extract plots from last cycle
//------------------------------------------

auto obj = mCcdbObjects.find(hbPacketsSourceName());
if (obj != mCcdbObjects.end()) {
mHBPacketsOnCycle.reset();
mHBPacketsOnCycle = std::make_unique<HistoOnCycle<TH2FRatio>>();
}

//----------------------------------
// HeartBeat packets plotters
//----------------------------------
Expand All @@ -85,25 +74,24 @@ void DecodingPostProcessing::createHeartBeatPacketsHistos(Trigger t, repository:
mHBPacketsPlotter = std::make_unique<HeartBeatPacketsPlotter>("HeartBeatPackets/", mFullHistos);
mHBPacketsPlotter->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);

mHBPacketsPlotterOnCycle.reset();
mHBPacketsPlotterOnCycle = std::make_unique<HeartBeatPacketsPlotter>("HeartBeatPackets/LastCycle/", mFullHistos);
mHBPacketsPlotterOnCycle->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);
if (mEnableLastCycleHistos) {
// Helpers to extract plots from last cycle
auto obj = mCcdbObjects.find(hbPacketsSourceName());
if (obj != mCcdbObjects.end()) {
mHBPacketsOnCycle.reset();
mHBPacketsOnCycle = std::make_unique<HistoOnCycle<TH2FRatio>>();
}

mHBPacketsPlotterOnCycle.reset();
mHBPacketsPlotterOnCycle = std::make_unique<HeartBeatPacketsPlotter>("HeartBeatPackets/LastCycle/", mFullHistos);
mHBPacketsPlotterOnCycle->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);
}
}

//_________________________________________________________________________________________

void DecodingPostProcessing::createSyncStatusHistos(Trigger t, repository::DatabaseInterface* qcdb)
{
//------------------------------------------
// Helpers to extract plots from last cycle
//------------------------------------------

auto obj = mCcdbObjects.find(syncStatusSourceName());
if (obj != mCcdbObjects.end()) {
mSyncStatusOnCycle.reset();
mSyncStatusOnCycle = std::make_unique<HistoOnCycle<TH2FRatio>>();
}

//----------------------------------
// Sync status plotters
//----------------------------------
Expand All @@ -112,9 +100,18 @@ void DecodingPostProcessing::createSyncStatusHistos(Trigger t, repository::Datab
mSyncStatusPlotter = std::make_unique<FECSyncStatusPlotter>("SyncErrors/");
mSyncStatusPlotter->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);

mSyncStatusPlotterOnCycle.reset();
mSyncStatusPlotterOnCycle = std::make_unique<FECSyncStatusPlotter>("SyncErrors/LastCycle/");
mSyncStatusPlotterOnCycle->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);
if (mEnableLastCycleHistos) {
// Helpers to extract plots from last cycle
auto obj = mCcdbObjects.find(syncStatusSourceName());
if (obj != mCcdbObjects.end()) {
mSyncStatusOnCycle.reset();
mSyncStatusOnCycle = std::make_unique<HistoOnCycle<TH2FRatio>>();
}

mSyncStatusPlotterOnCycle.reset();
mSyncStatusPlotterOnCycle = std::make_unique<FECSyncStatusPlotter>("SyncErrors/LastCycle/");
mSyncStatusPlotterOnCycle->publish(getObjectsManager(), core::PublicationPolicy::ThroughStop);
}
}

//_________________________________________________________________________________________
Expand All @@ -125,6 +122,8 @@ void DecodingPostProcessing::initialize(Trigger t, framework::ServiceRegistryRef
const auto& activity = t.activity;

mFullHistos = getConfigurationParameter<bool>(mCustomParameters, "FullHistos", mFullHistos, activity);
mEnableLastCycleHistos = getConfigurationParameter<bool>(mCustomParameters, "EnableLastCycleHistos", mEnableLastCycleHistos, activity);
mEnableTrending = getConfigurationParameter<bool>(mCustomParameters, "EnableTrending", mEnableTrending, activity);

mCcdbObjects.clear();
mCcdbObjects.emplace(errorsSourceName(), CcdbObjectHelper());
Expand Down Expand Up @@ -176,9 +175,11 @@ void DecodingPostProcessing::updateDecodingErrorsHistos(Trigger t, repository::D
TH2FRatio* hr = obj->second.get<TH2FRatio>();
if (hr) {
mErrorsPlotter->update(hr);
// extract the average occupancies on the last cycle
mErrorsOnCycle->update(hr);
mErrorsPlotterOnCycle->update(mErrorsOnCycle.get());
if (mEnableLastCycleHistos) {
// extract the average occupancies on the last cycle
mErrorsOnCycle->update(hr);
mErrorsPlotterOnCycle->update(mErrorsOnCycle.get());
}
}
}
}
Expand All @@ -192,9 +193,11 @@ void DecodingPostProcessing::updateHeartBeatPacketsHistos(Trigger t, repository:
TH2FRatio* hr = obj->second.get<TH2FRatio>();
if (hr) {
mHBPacketsPlotter->update(hr);
// extract the average occupancies on the last cycle
mHBPacketsOnCycle->update(hr);
mHBPacketsPlotterOnCycle->update(mHBPacketsOnCycle.get());
if (mEnableLastCycleHistos) {
// extract the average occupancies on the last cycle
mHBPacketsOnCycle->update(hr);
mHBPacketsPlotterOnCycle->update(mHBPacketsOnCycle.get());
}
}
}
}
Expand All @@ -208,9 +211,11 @@ void DecodingPostProcessing::updateSyncStatusHistos(Trigger t, repository::Datab
TH2F* hr = obj->second.get<TH2FRatio>();
if (hr) {
mSyncStatusPlotter->update(hr);
// extract the average occupancies on the last cycle
mSyncStatusOnCycle->update(hr);
mSyncStatusPlotterOnCycle->update(mSyncStatusOnCycle.get());
if (mEnableLastCycleHistos) {
// extract the average occupancies on the last cycle
mSyncStatusOnCycle->update(hr);
mSyncStatusPlotterOnCycle->update(mSyncStatusOnCycle.get());
}
}
}
}
Expand Down
Loading