Skip to content

CTP: Change in RawDataQcTask #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Barthelemy merged 1 commit into from
Apr 17, 2025
Merged

CTP: Change in RawDataQcTask #2538

Barthelemy merged 1 commit into from
Apr 17, 2025

Conversation

@lhusova
Copy link
Contributor

@lhusova lhusova commented Apr 16, 2025

Addition parameter to turn off the consistency check. @lietava, please have a look.

@lietava
Copy link
Contributor

lietava commented Apr 16, 2025

@lhusova ok for me

@lietava
Copy link
Contributor

lietava commented Apr 17, 2025

Hi @Barthelemy , @knopers8 , please, can this be merged asap as we need to deploy it in production. Cheers, Roman.

@Barthelemy
Copy link
Collaborator

Barthelemy commented Apr 17, 2025

@lietava When you say to deploy it in production, do you mean at P2 ? because merging will not do that, we would need to prepare a patch.

@Barthelemy Barthelemy merged commit 43c72f0 into AliceO2Group:master Apr 17, 2025
6 checks passed
@lietava
Copy link
Contributor

lietava commented Apr 17, 2025

@Barthelemy thanks. Yes, I spoke with pippo - he agrees. Who van do the patch, please ?

@Barthelemy
Copy link
Collaborator

Barthelemy commented Apr 17, 2025

@lietava I will prepare the patch, but @vascobarroso has to approve the installation. I feel that installing something the day before a long weekend is really calling for trouble. Is it preventing you from running ?

Barthelemy pushed a commit that referenced this pull request Apr 17, 2025
@lhusova @Barthelemy
add parameter to turn off the consistency check (#2538)
49e0510 
Co-authored-by: Lucia Anna Tarasovicova <lucia.anna.husova@cern.ch>
@Barthelemy
Copy link
Collaborator

Barthelemy commented Apr 17, 2025

https://github.com/AliceO2Group/QualityControl/releases/tag/v1.171.1

@lietava
Copy link
Contributor

lietava commented Apr 17, 2025

Hi @Barthelemy , thanks for tag.
Then to your comment: there is new functionality which seems to have bug which is not understood. This fix should enable to switch it on/off new functionality before bug is understood. Otherwise we would run without ctp qc which is also case if the bug is here in this PR. So it is for @vascobarroso to decide. I would vote for installation before the first stable beams.

lietava
lietava reviewed Apr 22, 2025
View reviewed changes
Modules/CTP/include/CTP/RawDataQcTask.h
long int mTimestamp;
std::string classNames[nclasses];
int mIndexMBclass = -1; // index for the MB ctp class, which is used as scaling for the ratios
bool mConsistCheck = 0;
Copy link
Contributor

@lietava lietava Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhusova This variable is not used - can be removed at next modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Barthelemy Barthelemy Barthelemy approved these changes

@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner

@justonedev1 justonedev1 Awaiting requested review from justonedev1 justonedev1 is a code owner

+1 more reviewer

@lietava lietava lietava left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lhusova @lietava @Barthelemy