Skip to content

CTP:Change in the RawDataQcTask #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 3 commits into from
May 20, 2025
Merged

CTP:Change in the RawDataQcTask #2553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5d4e71
fix for replay, confing read-out from ctx
May 15, 2025
ffaa43c
fix clang
May 15, 2025
27140df
fix DecodeInps for Consistency Check
May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Modules/CTP/include/CTP/RawDataQcTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ class CTPRawDataReaderTask final : public TaskInterface
std::string classNames[nclasses];
int mIndexMBclass = -1; // index for the MB ctp class, which is used as scaling for the ratios
bool mConsistCheck = 0;
bool mReadCTPconfigInMonitorData = 0;
const o2::ctp::CTPConfiguration* mCTPconfig = nullptr;
std::string mMBclassName;
std::array<uint64_t, o2::ctp::CTP_NCLASSES> mClassErrorsA;
};

} // namespace o2::quality_control_modules::ctp
Expand Down
117 changes: 80 additions & 37 deletions Modules/CTP/src/RawDataQcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ void CTPRawDataReaderTask::initialize(o2::framework::InitContext& /*ctx*/)
mHistoBCMinBias2 = std::make_unique<TH1D>("bcMinBias2", "BC position MB2", norbits, 0, norbits);
mHistoInputRatios = std::make_unique<TH1DRatio>("inputRatio", "Input Ratio to MTVX; Input; Ratio;", ninps, 0, ninps, true);
mHistoClassRatios = std::make_unique<TH1DRatio>("classRatio", "Class Ratio to MB; Class; Ratio", nclasses, 0, nclasses, true);
mHistoDecodeError = std::make_unique<TH1D>("decodeError", "Errors from decoder", 10, 1, 11);
mHistoDecodeError = std::make_unique<TH1D>("decodeError", "Errors from decoder", nclasses, 0, nclasses);
getObjectsManager()->startPublishing(mHistoInputs.get());
getObjectsManager()->startPublishing(mHistoClasses.get());
getObjectsManager()->startPublishing(mHistoClassRatios.get());
Expand All @@ -61,7 +61,6 @@ void CTPRawDataReaderTask::initialize(o2::framework::InitContext& /*ctx*/)
getObjectsManager()->startPublishing(mHistoDecodeError.get());

mDecoder.setDoLumi(1);
mDecoder.setDecodeInps(1);
mDecoder.setDoDigits(1);
for (size_t i = 0; i < nclasses; i++) {
classNames[i] = "";
Expand All @@ -84,7 +83,12 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
mRunNumber = activity.mId;
mTimestamp = activity.mValidity.getMin();

auto MBclassName = getFromExtendedConfig<string>(activity, mCustomParameters, "MBclassName", "CMTVX-B-NOPF");
std::string readCTPConfig = getFromExtendedConfig<string>(activity, mCustomParameters, "readCTPconfigInMonitorData", "false");
if (readCTPConfig == "true") {
mReadCTPconfigInMonitorData = true;
}

mMBclassName = getFromExtendedConfig<string>(activity, mCustomParameters, "MBclassName", "CMTVX-B-NOPF");

std::string run = std::to_string(mRunNumber);
std::string ccdbName = mCustomParameters["ccdbName"];
Expand All @@ -93,40 +97,42 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
}
/// the ccdb reading to be futher discussed
// o2::ctp::CTPRunManager::setCCDBHost(ccdbName);
bool ok;
// o2::ctp::CTPConfiguration CTPconfig = o2::ctp::CTPRunManager::getConfigFromCCDB(mTimestamp, run, ok);
auto& mgr = o2::ccdb::BasicCCDBManager::instance();
mgr.setURL(ccdbName);
map<string, string> metadata; // can be empty
metadata["runNumber"] = run;
auto ctpconfigdb = mgr.getSpecific<o2::ctp::CTPConfiguration>(o2::ctp::CCDBPathCTPConfig, mTimestamp, metadata);
if (ctpconfigdb == nullptr) {
LOG(info) << "CTP config not in database, timestamp:" << mTimestamp;
ok = 0;
} else {
// ctpconfigdb->printStream(std::cout);
LOG(info) << "CTP config found. Run:" << run;
ok = 1;
}
if (ok) {
// get the index of the MB reference class
ILOG(Info, Support) << "CTP config found, run:" << run << ENDM;
std::vector<o2::ctp::CTPClass> ctpcls = ctpconfigdb->getCTPClasses();
for (size_t i = 0; i < ctpcls.size(); i++) {
classNames[i] = ctpcls[i].name.c_str();
if (ctpcls[i].name.find(MBclassName) != std::string::npos) {
mIndexMBclass = ctpcls[i].getIndex() + 1;
break;
if (!mReadCTPconfigInMonitorData) {
bool ok;
auto& mgr = o2::ccdb::BasicCCDBManager::instance();
mgr.setURL(ccdbName);
map<string, string> metadata; // can be empty
metadata["runNumber"] = run;
auto ctpconfigdb = mgr.getSpecific<o2::ctp::CTPConfiguration>(o2::ctp::CCDBPathCTPConfig, mTimestamp, metadata);
if (ctpconfigdb == nullptr) {
Copy link
Collaborator

@Barthelemy Barthelemy May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to use a DPL input ?

Copy link
Contributor

@lietava lietava May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment we keep both options - to read directly and to read from dpl.
There is config parameter readCTPconfigInMonitorData which control these options.
The dpl part starts in: dpl

LOG(info) << "CTP config not in database, timestamp:" << mTimestamp;
ok = 0;
} else {
LOG(info) << "CTP config found. Run:" << run;
ok = 1;
}
if (ok) {
// get the index of the MB reference class
ILOG(Info, Support) << "CTP config found, run:" << run << ENDM;
std::vector<o2::ctp::CTPClass> ctpcls = ctpconfigdb->getCTPClasses();
for (size_t i = 0; i < ctpcls.size(); i++) {
classNames[i] = ctpcls[i].name.c_str();
if (ctpcls[i].name.find(mMBclassName) != std::string::npos) {
mIndexMBclass = ctpcls[i].getIndex() + 1;
break;
}
}
mDecoder.setCTPConfig(*ctpconfigdb);
} else {
ILOG(Warning, Support) << "CTP config not found, run:" << run << ENDM;
}
mDecoder.setCTPConfig(*ctpconfigdb);
} else {
ILOG(Warning, Support) << "CTP config not found, run:" << run << ENDM;
}
if (mIndexMBclass == -1) {
MBclassName = "CMBV0 (default)";
mIndexMBclass = 1;
if (mIndexMBclass == -1) {
mMBclassName = "CMBV0 (default)";
mIndexMBclass = 1;
}
mHistoClassRatios->SetTitle(Form("Class Ratio to %s", mMBclassName.c_str()));
}

std::string nameInput1 = getFromExtendedConfig<string>(activity, mCustomParameters, "MB1inputName", "MTVX");
std::string nameInput2 = getFromExtendedConfig<string>(activity, mCustomParameters, "MB2inputName", "MT0A");

Expand Down Expand Up @@ -201,12 +207,12 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
titleX2 += Form(" - %d", mShiftInput2);
}
mHistoBCMinBias2->SetTitle(Form("%s; %s; %s", title2.Data(), titleX2.Data(), titley2.Data()));
mHistoClassRatios->SetTitle(Form("Class Ratio to %s", MBclassName.c_str()));
mHistoInputRatios->SetTitle(Form("Input Ratio to %s", nameInput1.c_str()));

std::string performConsistencyCheck = getFromExtendedConfig<string>(activity, mCustomParameters, "consistencyCheck", "true");
if (performConsistencyCheck == "true") {
mDecoder.setCheckConsistency(1);
mDecoder.setDecodeInps(1);
} else {
mDecoder.setCheckConsistency(0);
}
Expand All @@ -226,10 +232,47 @@ void CTPRawDataReaderTask::monitorData(o2::framework::ProcessingContext& ctx)
std::vector<o2::ctp::LumiInfo> lumiPointsHBF1;
std::vector<o2::ctp::CTPDigit> outputDigits;

if (mReadCTPconfigInMonitorData) {
if (mCTPconfig == nullptr) {
mCTPconfig = ctx.inputs().get<o2::ctp::CTPConfiguration*>("ctp-config").get();
// mCTPconfig = ctpConfigPtr.get();
if (mCTPconfig != nullptr) {
ILOG(Info, Support) << "CTP config found" << ENDM;
std::vector<o2::ctp::CTPClass> ctpcls = mCTPconfig->getCTPClasses();
for (size_t i = 0; i < ctpcls.size(); i++) {
classNames[i] = ctpcls[i].name.c_str();
if (ctpcls[i].name.find(mMBclassName) != std::string::npos) {
mIndexMBclass = ctpcls[i].getIndex() + 1;
break;
}
}
mDecoder.setCTPConfig(*mCTPconfig);
}
}
for (int i = 0; i < nclasses; i++) {
if (classNames[i] == "") {
mHistoClasses.get()->GetXaxis()->SetBinLabel(i + 1, Form("%i", i + 1));
mHistoClassRatios.get()->GetXaxis()->SetBinLabel(i + 1, Form("%i", i + 1));
} else {
mHistoClasses.get()->GetXaxis()->SetBinLabel(i + 1, Form("%s", classNames[i].c_str()));
mHistoClassRatios.get()->GetXaxis()->SetBinLabel(i + 1, Form("%s", classNames[i].c_str()));
}
}

if (mIndexMBclass == -1) {
mMBclassName = "CMBV0 (default)";
mIndexMBclass = 1;
}
mHistoClassRatios->SetTitle(Form("Class Ratio to %s", mMBclassName.c_str()));
}

o2::framework::InputRecord& inputs = ctx.inputs();
int ret = mDecoder.decodeRaw(inputs, filter, outputDigits, lumiPointsHBF1);
if (ret > 0) {
mHistoDecodeError->Fill(log2(ret) + 1.5);
mClassErrorsA = mDecoder.getClassErrorsA();
for (size_t i = 0; i < o2::ctp::CTP_NCLASSES; i++) {
if (mClassErrorsA[i] > 0) {
mHistoDecodeError->Fill(i, mClassErrorsA[i]);
}
}

// reading the ctp inputs and ctp classes
Expand Down
10 changes: 7 additions & 3 deletions Modules/CTP/src/qc-ctp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,22 @@
"detectorName": "CTP",
"cycleDurationSeconds": "60",
"resetAfterCycles": "1",
"dataSource": {
"dataSources": [{
"type": "dataSamplingPolicy",
"name": "ctp-raw"
},
},{
"type": "direct",
"query": "ctp-config:CTP/CONFIG/0?lifetime=condition&ccdb-path=CTP/Config/Config&ccdb-run-dependent=1s"
}],
"extendedTaskParameters": {
"default": {
"default": {
"ccdbName": "https://alice-ccdb.cern.ch",
"MBclassName" : "CMTVX-B-NOPF",
"MB1inputName" : "MTVX",
"MB2inputName" : "MVBA",
"consistencyCheck" : "false"
"consistencyCheck" : "true",
"readCTPconfigInMonitorData": "true"
}
},
"PHYSICS": {
Expand Down