Skip to content

QC-1289 Possibility to use a token with BKP client #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 1 commit into from
Jun 5, 2025
Merged

QC-1289 Possibility to use a token with BKP client #2558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Framework/src/Bookkeeping.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ void Bookkeeping::init(const std::string& url)
}

try {
mClient = BkpClientFactory::create(url);
if (auto tokenEnv = std::getenv("QC_BKP_CLIENT_TOKEN"); tokenEnv != NULL) {
mClient = BkpClientFactory::create(url, tokenEnv);
} else {
mClient = BkpClientFactory::create(url);
}
} catch (std::runtime_error& error) {
ILOG(Warning, Support) << "Error connecting to Bookkeeping: " << error.what() << ENDM;
return;
Expand Down
2 changes: 1 addition & 1 deletion doc/Framework.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ Propagation can be enabled by adding the following key-value pair to Check/Aggre

Using it for Aggregators is discouraged, as the information on which exact Check failed is lost or at least obfuscated.

Also, make sure that the configuration file includes the Bookkeeping URL.
Also, make sure that the configuration file includes the Bookkeeping URL and there is an env var `QC_BKP_CLIENT_TOKEN` with authentication token for setups external to P2.

Check results are converted into Flags, which are documented in [O2/DataFormats/QualityControl](https://github.com/AliceO2Group/AliceO2/tree/dev/DataFormats/QualityControl).
Information about the object validity is preserved, which allows for time-based flagging of good/bad data.
Expand Down