Skip to content

[EMCAL-792] Adjust warning and error messages in case of raw errors #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 1 commit into from
Jun 5, 2025
Merged

[EMCAL-792] Adjust warning and error messages in case of raw errors #2560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Modules/EMCAL/src/RawErrorCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,13 +269,13 @@ Quality RawErrorCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
if (result != Quality::Bad) {
result = Quality::Bad;
}
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above threshold " + std::to_string(thresholdTotalErrBad));
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above critical threshold: Call oncall!");

} else if (numErrors > thresholdTotalErrWarn) { // Number of raw error exceeds the threshold but is considered to be okay. Error can be fixed at beam dump
if (result != Quality::Medium) {
result = Quality::Medium;
}
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above threshold " + std::to_string(thresholdTotalErrWarn) + " not critical ");
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " below critical threshold: Call oncall at beam dump");
}
}
} else if (std::find(errorhists.begin(), errorhists.end(), mo->getName()) != errorhists.end()) {
Expand All @@ -301,7 +301,7 @@ Quality RawErrorCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
if (result != Quality::Bad) {
result = Quality::Bad;
}
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above threshold " + std::to_string(threshold));
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above critical threshold: Call oncall!");
}
}
} else if (std::find(gainhists.begin(), gainhists.end(), mo->GetName()) != gainhists.end()) {
Expand Down Expand Up @@ -390,7 +390,7 @@ void RawErrorCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkRes
// Notify about found errors on the infoLogger:
if (mNotifyInfologger) {
for (const auto& flag : checkResult.getFlags()) {
ILOG(Warning, Devel) << "Non-critical raw Error in " << mo->GetName() << " found: " << flag.second << " call EMCal oncall at beam dump!" << ENDM;
ILOG(Warning, Devel) << "Non-critical raw Error in " << mo->GetName() << " found: " << flag.second << ENDM;
}
}
}
Expand Down