Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Framework/include/QualityControl/Activity.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ class Activity
ValidityInterval validity = gFullValidityInterval,
const std::string& beamType = "",
const std::string& partitionName = "",
int fillNumber = 0)
int fillNumber = 0,
int originalId = 0)
: mId(id),
mType(type),
mPeriodName(periodName),
Expand All @@ -48,7 +49,8 @@ class Activity
mValidity(validity),
mBeamType(beamType),
mPartitionName(partitionName),
mFillNumber(fillNumber) {}
mFillNumber(fillNumber),
mOriginalId(originalId) {}

/// Copy constructor
Activity(const Activity& other) = default;
Expand Down Expand Up @@ -80,6 +82,7 @@ class Activity
std::string mBeamType{};
std::string mPartitionName{};
int mFillNumber{ 0 };
int mOriginalId{ 0 }; // original run number of REPLAY runs

ClassDef(Activity, 6);
};
Expand Down
1 change: 1 addition & 0 deletions Framework/include/QualityControl/ActivityHelpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ Activity commonActivityFields(const RangeOfActivities auto& activities)
setMemberIfCommon(result, activities, &Activity::mBeamType);
setMemberIfCommon(result, activities, &Activity::mPartitionName);
setMemberIfCommon(result, activities, &Activity::mFillNumber);
setMemberIfCommon(result, activities, &Activity::mOriginalId);
return result;
}

Expand Down
1 change: 1 addition & 0 deletions Framework/include/QualityControl/CommonSpec.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ struct CommonSpec {
std::string activityBeamType;
std::string activityPartitionName;
int activityFillNumber = 0;
int activityOriginalNumber = 0;
std::string monitoringUrl = "infologger:///debug?qc";
std::string consulUrl;
std::string conditionDBUrl = "http://ccdb-test.cern.ch:8080";
Expand Down
1 change: 1 addition & 0 deletions Framework/include/QualityControl/ObjectMetadataKeys.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ constexpr auto periodName = "PeriodName";
constexpr auto beamType = "BeamType";
constexpr auto fillNumber = "FillNumber";
constexpr auto partitionName = "PartitionName";
constexpr auto originalRunNumber = "OriginalRunNumber";

} // namespace o2::quality_control::repository::metadata_keys

Expand Down
6 changes: 4 additions & 2 deletions Framework/src/Activity.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ std::ostream& operator<<(std::ostream& out, const Activity& activity)
<< ", " << metadata_keys::validUntil << ": " << activity.mValidity.getMax()
<< ", " << metadata_keys::beamType << ": '" << activity.mBeamType << "'"
<< ", " << metadata_keys::partitionName << ": '" << activity.mPartitionName << "'"
<< ", " << metadata_keys::fillNumber << ": '" << activity.mFillNumber << "'";
<< ", " << metadata_keys::fillNumber << ": '" << activity.mFillNumber << "'"
<< ", " << metadata_keys::originalRunNumber << ": '" << activity.mOriginalId << "'";
return out;
}

Expand Down Expand Up @@ -72,7 +73,8 @@ bool Activity::operator==(const Activity& other) const
mPassName == other.mPassName &&
mProvenance == other.mProvenance &&
mValidity == other.mValidity &&
mBeamType == other.mBeamType;
mBeamType == other.mBeamType &&
mOriginalId == other.mOriginalId;
}

} // namespace o2::quality_control::core
3 changes: 2 additions & 1 deletion Framework/src/AggregatorRunnerFactory.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ AggregatorRunnerConfig AggregatorRunnerFactory::extractRunnerConfig(const core::
{ commonSpec.activityStart, commonSpec.activityEnd },
commonSpec.activityBeamType,
commonSpec.activityPartitionName,
commonSpec.activityFillNumber
commonSpec.activityFillNumber,
commonSpec.activityOriginalNumber
};

return {
Expand Down
3 changes: 2 additions & 1 deletion Framework/src/CheckRunnerFactory.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ CheckRunnerConfig CheckRunnerFactory::extractConfig(const CommonSpec& commonSpec
{ commonSpec.activityStart, commonSpec.activityEnd },
commonSpec.activityBeamType,
commonSpec.activityPartitionName,
commonSpec.activityFillNumber
commonSpec.activityFillNumber,
commonSpec.activityOriginalNumber
};
return {
commonSpec.database,
Expand Down
1 change: 1 addition & 0 deletions Framework/src/InfrastructureSpecReader.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ CommonSpec InfrastructureSpecReader::readSpecEntry<CommonSpec>(const std::string
spec.activityBeamType = commonTree.get<std::string>("Activity.beamType", spec.activityBeamType);
spec.activityPartitionName = commonTree.get<std::string>("Activity.partitionName", spec.activityPartitionName);
spec.activityFillNumber = commonTree.get<int>("Activity.fillNumber", spec.activityFillNumber);
spec.activityOriginalNumber = commonTree.get<int>("Activity.originalNumber", spec.activityOriginalNumber);
spec.monitoringUrl = commonTree.get<std::string>("monitoring.url", spec.monitoringUrl);
spec.consulUrl = commonTree.get<std::string>("consul.url", spec.consulUrl);
spec.conditionDBUrl = commonTree.get<std::string>("conditionDB.url", spec.conditionDBUrl);
Expand Down
3 changes: 2 additions & 1 deletion Framework/src/TaskRunnerFactory.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ TaskRunnerConfig TaskRunnerFactory::extractConfig(const CommonSpec& globalConfig
{ globalConfig.activityStart, globalConfig.activityEnd },
globalConfig.activityBeamType,
globalConfig.activityPartitionName,
globalConfig.activityFillNumber
globalConfig.activityFillNumber,
globalConfig.activityOriginalNumber
};

o2::globaltracking::RecoContainer rd;
Expand Down
4 changes: 3 additions & 1 deletion Framework/src/runnerUtils.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ Activity computeActivity(framework::ServiceRegistryRef services, const Activity&
auto periodName = computeStringActivityField(services, "lhc_period", fallbackActivity.mPeriodName);
auto fillNumber = computeNumericalActivityField<int>(services, "fill_info_fill_number", fallbackActivity.mFillNumber);
auto beam_type = computeStringActivityField(services, "pdp_beam_type", fallbackActivity.mBeamType);
auto originalRunNumber = computeNumericalActivityField<int>(services, "original_run_number", fallbackActivity.mOriginalId);

Activity activity(
runNumber,
Expand All @@ -116,7 +117,8 @@ Activity computeActivity(framework::ServiceRegistryRef services, const Activity&
{ runStartTimeMs, runEndTimeMs },
beam_type,
partitionName,
fillNumber);
fillNumber,
originalRunNumber);

return activity;
}
Expand Down
3 changes: 2 additions & 1 deletion doc/Configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ should not be present in real configuration files.
"end" : "1234", "": "Activity end time in ms since epoch. One can use it as a filter in post-processing",
"beamType" : "pp", "": "Beam type: `pp`, `PbPb`, `pPb` ",
"partitionName" : "", "": "Partition name",
"fillNumber" : "123", "": "Fill Number"
"fillNumber" : "123", "": "Fill Number",
"originalRunNumber" : "100", "": "When it is a REPLAY run, this contains the original run number"
},
"monitoring": { "": "Configuration of the Monitoring library.",
"url": "infologger:///debug?qc", "": ["URI to the Monitoring backend. Refer to the link below for more info:",
Expand Down