Skip to content

[QC-1082] filter empty qos and mos in datasource #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 1 commit into from
Jul 9, 2025
Merged

[QC-1082] filter empty qos and mos in datasource #2579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions Framework/src/InfrastructureSpecReader.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,12 @@ DataSourceSpec InfrastructureSpecReader::readSpecEntry<DataSourceSpec>(const std
dss.inputs = { { dss.name, TaskRunner::createTaskDataOrigin(detectorName), TaskRunner::createTaskDataDescription(dss.name), 0, Lifetime::Sporadic } };
if (dataSourceTree.count("MOs") > 0) {
for (const auto& moName : dataSourceTree.get_child("MOs")) {
dss.subInputs.push_back(moName.second.get_value<std::string>());
const auto mo = moName.second.get_value<std::string>();
if (!mo.empty()) {
dss.subInputs.push_back(std::move(mo));
} else {
ILOG(Warning, Ops) << "Data source of type Task with name: " << dss.name << " contains empty mo, ignoring, but configuration should be fixed." << ENDM;
}
}
}
break;
Expand All @@ -245,7 +250,12 @@ DataSourceSpec InfrastructureSpecReader::readSpecEntry<DataSourceSpec>(const std
dss.inputs = { { dss.name, TaskRunner::createTaskDataOrigin(detectorName, true), TaskRunner::createTaskDataDescription(taskName), 0, Lifetime::Sporadic } };
if (dataSourceTree.count("MOs") > 0) {
for (const auto& moName : dataSourceTree.get_child("MOs")) {
dss.subInputs.push_back(moName.second.get_value<std::string>());
const auto mo = moName.second.get_value<std::string>();
if (!mo.empty()) {
dss.subInputs.push_back(std::move(mo));
} else {
ILOG(Warning, Ops) << "Data source of type TaskMovingWindow with name: " << dss.name << " contains empty mo, ignoring, but configuration should be fixed." << ENDM;
}
}
}
break;
Expand All @@ -270,7 +280,12 @@ DataSourceSpec InfrastructureSpecReader::readSpecEntry<DataSourceSpec>(const std
dss.inputs = { { dss.name, Check::createCheckDataOrigin(detectorName), Check::createCheckDataDescription(dss.name), 0, Lifetime::Sporadic } };
if (dataSourceTree.count("QOs") > 0) {
for (const auto& moName : dataSourceTree.get_child("QOs")) {
dss.subInputs.push_back(moName.second.get_value<std::string>());
const auto qo = moName.second.get_value<std::string>();
if (!qo.empty()) {
dss.subInputs.push_back(std::move(qo));
} else {
ILOG(Warning, Ops) << "Data source of type Check with name: " << dss.name << " contains empty qo, ignoring, but configuration should be fixed." << ENDM;
}
}
}
break;
Expand All @@ -282,7 +297,12 @@ DataSourceSpec InfrastructureSpecReader::readSpecEntry<DataSourceSpec>(const std
dss.inputs = { { dss.name, Check::createCheckDataOrigin(detectorName), AggregatorRunner::createAggregatorRunnerDataDescription(dss.name), 0, Lifetime::Sporadic } };
if (dataSourceTree.count("QOs") > 0) {
for (const auto& moName : dataSourceTree.get_child("QOs")) {
dss.subInputs.push_back(moName.second.get_value<std::string>());
const auto qo = moName.second.get_value<std::string>();
if (!qo.empty()) {
dss.subInputs.push_back(std::move(qo));
} else {
ILOG(Warning, Ops) << "Data source of type Aggregator with name: " << dss.name << " contains empty qo, ignoring, but configuration should be fixed." << ENDM;
}
}
}
break;
Expand Down