Skip to content

MID: fixed Digits check result in case of noisy boards #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 1 commit into from
Jul 29, 2025
Merged

MID: fixed Digits check result in case of noisy boards #2586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 35 additions & 11 deletions Modules/MUON/MID/src/DigitsQcCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ Quality DigitsQcCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
qual = Quality::Null;
} else if (mean > mMeanMultThreshold || mean < mMinMultThreshold) {
qual = Quality::Bad;
result = qual;
++nBad;
} else if (mean > mMeanMultThreshold / 2.) {
qual = Quality::Medium;
Expand Down Expand Up @@ -153,22 +152,44 @@ Quality DigitsQcCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
}
}
}
auto qual = Quality::Good;

auto qualBadLB = Quality::Good;
auto qualEmptyLB = Quality::Good;
if (nBadLB > 0) {
qual = Quality::Medium;
qualBadLB = Quality::Medium;
if (nBadLB > mNbBadLocalBoard) {
qual = Quality::Bad;
qualBadLB = Quality::Bad;
}
auto flag = o2::quality_control::FlagType();
qual.addFlag(flag, fmt::format("{} boards > {} kHz", nBadLB, mLocalBoardThreshold));
} else if (nEmptyLB > 0) {
qual = Quality::Medium;
qualBadLB.addFlag(flag, fmt::format("{} boards > {} kHz", nBadLB, mLocalBoardThreshold));
}
if (nEmptyLB > 0) {
qualEmptyLB = Quality::Medium;
if (nEmptyLB > mNbEmptyLocalBoard) {
qual = Quality::Bad;
qualEmptyLB = Quality::Bad;
}
auto flag = o2::quality_control::FlagType();
qual.addFlag(flag, fmt::format("{} boards empty", nEmptyLB));
qualEmptyLB.addFlag(flag, fmt::format("{} boards empty", nEmptyLB));
}

auto qual = Quality::Good;
if (qualBadLB.isWorseThan(qual)) {
qual.set(qualBadLB);
}
if (qualEmptyLB.isWorseThan(qual)) {
qual.set(qualEmptyLB);
}
// copy flags to aggregated quality
for (const auto& flag : qualBadLB.getFlags()) {
qual.addFlag(flag.first, flag.second);
}
for (const auto& flag : qualEmptyLB.getFlags()) {
qual.addFlag(flag.first, flag.second);
}
// copy metadata to aggregated quality
qual.addMetadata(qualBadLB.getMetadataMap());
qual.addMetadata(qualEmptyLB.getMetadataMap());

mQualityMap[item.second->getName()] = qual;
result = qual;
} // if mNTFInSeconds > 0.
Expand Down Expand Up @@ -251,8 +272,11 @@ void DigitsQcCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkRes
if (histo) {
if (mo->getName() == lbHistoName) {
// This is LocalBoardsMap and it was already scaled in the checker
if (!checkResult.getFlags().empty()) {
mHistoHelper.addLatex(histo, 0.12, 0.72, color, checkResult.getFlags().front().second.c_str());
float xFlagText = 0.12;
float yFlagText = 0.72;
for (const auto& flag : checkResult.getFlags()) {
mHistoHelper.addLatex(histo, xFlagText, yFlagText, color, flag.second.c_str());
yFlagText -= 0.1;
}
mHistoHelper.addLatex(histo, 0.3, 0.32, color, fmt::format("Quality::{}", checkResult.getName()));
histo->SetMaximum(zcontoursLoc4.back());
Expand Down