Skip to content

Add fully qualified names for std::string and std::map #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 2 commits into from
Aug 6, 2025
Merged

Add fully qualified names for std::string and std::map #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
069b30a
Add fully qualified names for std::string and std::map
mrtineide Aug 1, 2025
6ece80d
fix clang-format
knopers8 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Modules/CTP/src/CTPTrendingTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ void CTPTrendingTask::initCTP(Trigger& t)
// o2::ctp::CTPConfiguration CTPconfig = o2::ctp::CTPRunManager::getConfigFromCCDB(t.timestamp, run, ok);
auto& mgr = o2::ccdb::BasicCCDBManager::instance();
mgr.setURL(CCDBHost);
map<string, string> metadata; // can be empty
std::map<std::string, std::string> metadata; // can be empty
metadata["runNumber"] = run;
mgr.setFatalWhenNull(false);
auto ctpconfigdb = mgr.getSpecific<o2::ctp::CTPConfiguration>(o2::ctp::CCDBPathCTPConfig, t.timestamp, metadata);
Expand All @@ -80,11 +80,11 @@ void CTPTrendingTask::initCTP(Trigger& t)
}

for (int i = 0; i < 5; i++) {
mClassNames[i] = getFromExtendedConfig<string>(t.activity, mCustomParameters, mClassParameters[i], mClassNamesDefault[i]);
mClassNames[i] = getFromExtendedConfig<std::string>(t.activity, mCustomParameters, mClassParameters[i], mClassNamesDefault[i]);
if (mClassNames[i] == "") {
mClassNames[i] = mClassNamesDefault[i];
}
mInputNames[i] = getFromExtendedConfig<string>(t.activity, mCustomParameters, mInputParameters[i], mInputNamesDefault[i]);
mInputNames[i] = getFromExtendedConfig<std::string>(t.activity, mCustomParameters, mInputParameters[i], mInputNamesDefault[i]);
if (mInputNames[i] == "") {
mInputNames[i] = mInputNamesDefault[i];
}
Expand Down
12 changes: 6 additions & 6 deletions Modules/CTP/src/RawDataQcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
mRunNumber = activity.mId;
mTimestamp = activity.mValidity.getMin();

std::string readCTPConfig = getFromExtendedConfig<string>(activity, mCustomParameters, "readCTPconfigInMonitorData", "false");
std::string readCTPConfig = getFromExtendedConfig<std::string>(activity, mCustomParameters, "readCTPconfigInMonitorData", "false");
if (readCTPConfig == "true") {
mReadCTPconfigInMonitorData = true;
}

mMBclassName = getFromExtendedConfig<string>(activity, mCustomParameters, "MBclassName", "CMTVX-B-NOPF");
mMBclassName = getFromExtendedConfig<std::string>(activity, mCustomParameters, "MBclassName", "CMTVX-B-NOPF");

std::string run = std::to_string(mRunNumber);
std::string ccdbName = mCustomParameters["ccdbName"];
Expand All @@ -98,7 +98,7 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
bool ok;
auto& mgr = o2::ccdb::BasicCCDBManager::instance();
mgr.setURL(ccdbName);
map<string, string> metadata; // can be empty
std::map<std::string, std::string> metadata; // can be empty
metadata["runNumber"] = run;
auto ctpconfigdb = mgr.getSpecific<o2::ctp::CTPConfiguration>(o2::ctp::CCDBPathCTPConfig, mTimestamp, metadata);
if (ctpconfigdb == nullptr) {
Expand Down Expand Up @@ -130,8 +130,8 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
mHistoClassRatios->SetTitle(Form("Class Ratio to %s", mMBclassName.c_str()));
}

std::string nameInput1 = getFromExtendedConfig<string>(activity, mCustomParameters, "MB1inputName", "MTVX");
std::string nameInput2 = getFromExtendedConfig<string>(activity, mCustomParameters, "MB2inputName", "MT0A");
std::string nameInput1 = getFromExtendedConfig<std::string>(activity, mCustomParameters, "MB1inputName", "MTVX");
std::string nameInput2 = getFromExtendedConfig<std::string>(activity, mCustomParameters, "MB2inputName", "MT0A");

auto input1Tokens = o2::utils::Str::tokenize(nameInput1, ':', false, true);
if (input1Tokens.size() > 0) {
Expand Down Expand Up @@ -206,7 +206,7 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
mHistoBCMinBias2->SetTitle(Form("%s; %s; %s", title2.Data(), titleX2.Data(), titley2.Data()));
mHistoInputRatios->SetTitle(Form("Input Ratio to %s", nameInput1.c_str()));

std::string performConsistencyCheck = getFromExtendedConfig<string>(activity, mCustomParameters, "consistencyCheck", "true");
std::string performConsistencyCheck = getFromExtendedConfig<std::string>(activity, mCustomParameters, "consistencyCheck", "true");
if (performConsistencyCheck == "true") {
mDecoder.setCheckConsistency(1);
mDecoder.setDecodeInps(1);
Expand Down
2 changes: 1 addition & 1 deletion Modules/Common/src/CcdbInspectorTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ std::tuple<uint64_t, uint64_t, uint64_t, int> CcdbInspectorTask::getObjectInfo(c

void* CcdbInspectorTask::getObject(const std::string& path, std::type_info const& tinfo, uint64_t timestamp, const std::map<std::string, std::string>& metadata)
{
map<string, string> headers;
std::map<std::string, std::string> headers;
void* obj = mDatabase->retrieveAny(tinfo, path, metadata, timestamp, &headers);
ILOG(Debug, Devel) << "Retrieved '" << path << "' from db '" << mDatabaseUrl << "' for timestamp " << timestamp << ENDM;

Expand Down
2 changes: 1 addition & 1 deletion Modules/FIT/FDD/src/DigitQcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ void DigitQcTask::initialize(o2::framework::InitContext& /*ctx*/)

for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
obj->SetTitle((string("FDD ") + obj->GetTitle()).c_str());
obj->SetTitle((std::string("FDD ") + obj->GetTitle()).c_str());
}
// Timestamp
mMetaAnchorOutput = o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "metaAnchorOutput", "CycleDurationNTF");
Expand Down
2 changes: 1 addition & 1 deletion Modules/FIT/FDD/src/DigitQcTaskLaser.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ void DigitQcTaskLaser::initialize(o2::framework::InitContext& /*ctx*/)

for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
obj->SetTitle((string("FDD Laser ") + obj->GetTitle()).c_str());
obj->SetTitle((std::string("FDD Laser ") + obj->GetTitle()).c_str());
}
}

Expand Down
2 changes: 1 addition & 1 deletion Modules/FIT/FDD/src/PostProcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ void PostProcTask::initialize(Trigger, framework::ServiceRegistryRef services)
for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
if (obj != nullptr) {
obj->SetTitle((string("FDD ") + obj->GetTitle()).c_str());
obj->SetTitle((std::string("FDD ") + obj->GetTitle()).c_str());
}
}

Expand Down
2 changes: 1 addition & 1 deletion Modules/FIT/FT0/src/DigitQcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ void DigitQcTask::initialize(o2::framework::InitContext& /*ctx*/)

for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
obj->SetTitle((string("FT0 ") + obj->GetTitle()).c_str());
obj->SetTitle((std::string("FT0 ") + obj->GetTitle()).c_str());
}
//
mGoodPMbits_ChID = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "goodPMbits_ChID", 1 << o2::ft0::ChannelData::kIsCFDinADCgate);
Expand Down
2 changes: 1 addition & 1 deletion Modules/FIT/FV0/src/DigitQcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ void DigitQcTask::initialize(o2::framework::InitContext& /*ctx*/)

for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
obj->SetTitle((string("FV0 ") + obj->GetTitle()).c_str());
obj->SetTitle((std::string("FV0 ") + obj->GetTitle()).c_str());
}
// Timestamp
mMetaAnchorOutput = o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "metaAnchorOutput", "CycleDurationNTF");
Expand Down
2 changes: 1 addition & 1 deletion Modules/FIT/FV0/src/DigitQcTaskLaser.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ void DigitQcTaskLaser::initialize(o2::framework::InitContext& /*ctx*/)

for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
obj->SetTitle((string("FV0 Laser ") + obj->GetTitle()).c_str());
obj->SetTitle((std::string("FV0 Laser ") + obj->GetTitle()).c_str());
}
}

Expand Down
2 changes: 1 addition & 1 deletion Modules/FIT/FV0/src/PostProcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ void PostProcTask::initialize(Trigger, framework::ServiceRegistryRef services)
for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
if (obj != nullptr) {
obj->SetTitle((string("FV0 ") + obj->GetTitle()).c_str());
obj->SetTitle((std::string("FV0 ") + obj->GetTitle()).c_str());
}
}

Expand Down
2 changes: 1 addition & 1 deletion Modules/GLO/src/CTFSizeTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void CTFSize::initialize(o2::framework::InitContext& /*ctx*/)
mDefaultBinning[DetID::CTP] = "100, 1, 100";
mDefaultBinning[DetID::TST] = "1, 0, 1";

std::string detList = getFromConfig<string>(mCustomParameters, "detectors", "all");
std::string detList = getFromConfig<std::string>(mCustomParameters, "detectors", "all");
auto detMask = DetID::getMask(detList);

constexpr int nLogBins = 100;
Expand Down
2 changes: 1 addition & 1 deletion Modules/ITS/include/ITS/ITSNoisyPixelTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class ITSNoisyPixelTask : public TaskInterface
long int mTimestamp;

int mLocalGeometryFile = 0;
string mGeoTimestamp = "1640991600000";
std::string mGeoTimestamp = "1640991600000";
};
} // namespace o2::quality_control_modules::its

Expand Down
8 changes: 4 additions & 4 deletions Modules/ITS/include/ITS/ITSThresholdCalibrationTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ class ITSThresholdCalibrationTask : public TaskInterface
Int_t getBarrel(Int_t iLayer);
int getCurrentChip(int barrel, int chipid, int hic, int hs);

void doAnalysisTHR(string inString, int iScan);
void doAnalysisPixel(string inString);
void doAnalysisTHR(std::string inString, int iScan);
void doAnalysisPixel(std::string inString);

CalibrationResStructTHR CalibrationParserTHR(string input);
CalibrationResStructPixel CalibrationParserPixel(string input);
CalibrationResStructTHR CalibrationParserTHR(std::string input);
CalibrationResStructPixel CalibrationParserPixel(std::string input);

std::vector<TObject*> mPublishedObjects;

Expand Down
12 changes: 6 additions & 6 deletions Modules/ITS/src/ITSChipStatusCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ Quality ITSChipStatusCheck::check(std::map<std::string, std::shared_ptr<MonitorO
{

// limits to be used as "X,Y" --> BAD if at least X FFEIDs have at least Y chips each into error
std::vector<float> feeidlimitsIB = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "feeidlimitsIB", ""));
std::vector<float> feeidlimitsML = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "feeidlimitsML", ""));
std::vector<float> feeidlimitsOL = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "feeidlimitsOL", ""));
std::vector<int> excludedfeeid = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "excludedfeeid", ""));
std::vector<float> feeidlimitsIB = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "feeidlimitsIB", ""));
std::vector<float> feeidlimitsML = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "feeidlimitsML", ""));
std::vector<float> feeidlimitsOL = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "feeidlimitsOL", ""));
std::vector<int> excludedfeeid = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "excludedfeeid", ""));

if (feeidlimitsIB.size() != 2) {
ILOG(Error, Support) << "Incorrect setting for feeidlimitsIB, check .json. Using default 1,1" << ENDM;
Expand Down Expand Up @@ -117,7 +117,7 @@ void ITSChipStatusCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality che
TString status;
int textColor;

if ((string)mo->GetName() == "FEEIDOverview") {
if ((std::string)mo->GetName() == "FEEIDOverview") {
auto* h = dynamic_cast<TH1D*>(mo->getObject());
if (h == nullptr) {
ILOG(Error, Support) << "could not cast FEEIDOverview to TH1D*" << ENDM;
Expand All @@ -140,7 +140,7 @@ void ITSChipStatusCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality che
h->GetListOfFunctions()->Add(tInfo->Clone());
}

if ((string)mo->getName() == "StaveStatusOverview") {
if ((std::string)mo->getName() == "StaveStatusOverview") {
auto* h = dynamic_cast<TH2Poly*>(mo->getObject());
if (h == nullptr) {
ILOG(Error, Support) << "could not cast StaveStatusOverview to TH2Poly*" << ENDM;
Expand Down
10 changes: 5 additions & 5 deletions Modules/ITS/src/ITSClusterCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ Quality ITSClusterCheck::check(std::map<std::string, std::shared_ptr<MonitorObje
ILOG(Error, Support) << "could not cast general occupancy to TH2D*" << ENDM;
continue;
}
std::vector<int> skipxbins = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "skipxbinsoccupancy", ""));
std::vector<int> skipybins = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "skipybinsoccupancy", ""));
std::vector<int> skipxbins = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "skipxbinsoccupancy", ""));
std::vector<int> skipybins = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "skipybinsoccupancy", ""));
std::vector<std::pair<int, int>> xypairs;
for (int i = 0; i < (int)skipxbins.size(); i++) {
xypairs.push_back(std::make_pair(skipxbins[i], skipybins[i]));
Expand Down Expand Up @@ -140,9 +140,9 @@ std::string ITSClusterCheck::getAcceptedType() { return "TH2D"; }

void ITSClusterCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
{
std::vector<string> vPlotWithTextMessage = convertToArray<string>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "plotWithTextMessage", ""));
std::vector<string> vTextMessage = convertToArray<string>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "textMessage", ""));
std::map<string, string> ShifterInfoText;
std::vector<std::string> vPlotWithTextMessage = convertToArray<std::string>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "plotWithTextMessage", ""));
std::vector<std::string> vTextMessage = convertToArray<std::string>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "textMessage", ""));
std::map<std::string, std::string> ShifterInfoText;

if ((int)vTextMessage.size() == (int)vPlotWithTextMessage.size()) {
for (int i = 0; i < (int)vTextMessage.size(); i++) {
Expand Down
2 changes: 1 addition & 1 deletion Modules/ITS/src/ITSClusterTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ void ITSClusterTask::monitorData(o2::framework::ProcessingContext& ctx)
{

if (mTimestamp == -1) { // get dict from ccdb
mTimestamp = std::stol(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "dicttimestamp", "0"));
mTimestamp = std::stol(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "dicttimestamp", "0"));
long int ts = mTimestamp ? mTimestamp : ctx.services().get<o2::framework::TimingInfo>().creation;
ILOG(Debug, Devel) << "Getting dictionary from ccdb - timestamp: " << ts << ENDM;
std::map<std::string, std::string> metadata;
Expand Down
26 changes: 13 additions & 13 deletions Modules/ITS/src/ITSDecodingErrorCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,17 @@ Quality ITSDecodingErrorCheck::check(std::map<std::string, std::shared_ptr<Monit
end = std::chrono::high_resolution_clock::now();
TIME = std::chrono::duration_cast<std::chrono::seconds>(end - start).count();
}
std::vector<int> vDecErrorLimits = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "DecLinkErrorLimits", ""));
std::vector<int> vDecErrorLimits = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "DecLinkErrorLimits", ""));
if (vDecErrorLimits.size() != o2::itsmft::GBTLinkDecodingStat::NErrorsDefined) {
ILOG(Error, Support) << "Incorrect vector with DecodingError limits, check .json" << ENDM;
doFlatCheck = true;
}
std::vector<float> vDecErrorLimitsRatio = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "DecLinkErrorLimitsRatio", ""));
std::vector<float> vDecErrorLimitsRatio = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "DecLinkErrorLimitsRatio", ""));
if (vDecErrorLimitsRatio.size() != o2::itsmft::GBTLinkDecodingStat::NErrorsDefined) {
ILOG(Error, Support) << "Incorrect vector with DecodingError limits Ratio, check .json" << ENDM;
doFlatCheck = true;
}
std::vector<int> vDecErrorType = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "DecLinkErrorType", ""));
std::vector<int> vDecErrorType = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "DecLinkErrorType", ""));
if (vDecErrorType.size() != o2::itsmft::GBTLinkDecodingStat::NErrorsDefined) {
ILOG(Error, Support) << "Incorrect vector with DecodingError Type, check .json" << ENDM;
doFlatCheck = true;
Expand All @@ -59,7 +59,7 @@ Quality ITSDecodingErrorCheck::check(std::map<std::string, std::shared_ptr<Monit
for (auto& [moName, mo] : *moMap) {
(void)moName;

if ((string)mo->getName() == "General/ChipErrorPlots") {
if ((std::string)mo->getName() == "General/ChipErrorPlots") {
result = Quality::Good;
auto* h = dynamic_cast<TH1D*>(mo->getObject());
if (h == nullptr) {
Expand All @@ -70,7 +70,7 @@ Quality ITSDecodingErrorCheck::check(std::map<std::string, std::shared_ptr<Monit
result.set(Quality::Bad);
}

if ((string)mo->GetName() == "General/LinkErrorVsFeeid") {
if ((std::string)mo->GetName() == "General/LinkErrorVsFeeid") {

result = Quality::Good;
auto* h = dynamic_cast<TH2D*>(mo->getObject());
Expand Down Expand Up @@ -109,10 +109,10 @@ Quality ITSDecodingErrorCheck::check(std::map<std::string, std::shared_ptr<Monit
result.addFlag(o2::quality_control::FlagTypeFactory::Unknown(), Form("BAD: ID = %d, %s", ierr, std::string(statistics.ErrNames[ierr]).c_str()));

} // end of y axis loop
} // end of x axis loop
} // end of check on General/LinkErrorVsFeeid
} // end of x axis loop
} // end of check on General/LinkErrorVsFeeid

if (((string)mo->getName()).find("General/LinkErrorPlots") != std::string::npos) {
if (((std::string)mo->getName()).find("General/LinkErrorPlots") != std::string::npos) {
result = Quality::Good;
auto* h = dynamic_cast<TH1D*>(mo->getObject());
if (h == nullptr) {
Expand Down Expand Up @@ -164,9 +164,9 @@ Quality ITSDecodingErrorCheck::check(std::map<std::string, std::shared_ptr<Monit

void ITSDecodingErrorCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
{
std::vector<string> vPlotWithTextMessage = convertToArray<string>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "plotWithTextMessage", ""));
std::vector<string> vTextMessage = convertToArray<string>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "textMessage", ""));
std::map<string, string> ShifterInfoText;
std::vector<std::string> vPlotWithTextMessage = convertToArray<std::string>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "plotWithTextMessage", ""));
std::vector<std::string> vTextMessage = convertToArray<std::string>(o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "textMessage", ""));
std::map<std::string, std::string> ShifterInfoText;

if ((int)vTextMessage.size() == (int)vPlotWithTextMessage.size()) {
for (int i = 0; i < (int)vTextMessage.size(); i++) {
Expand All @@ -183,7 +183,7 @@ void ITSDecodingErrorCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality
TString status;
int textColor;

if (((string)mo->GetName()).find("General/LinkErrorVsFeeid") != std::string::npos) {
if (((std::string)mo->GetName()).find("General/LinkErrorVsFeeid") != std::string::npos) {

auto* h = dynamic_cast<TH2D*>(mo->getObject());
if (h == nullptr) {
Expand All @@ -207,7 +207,7 @@ void ITSDecodingErrorCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality

} // end of beautify LinkErrorVsFeeid

if ((((string)mo->getName()).find("General/LinkErrorPlots") != std::string::npos) || (mo->getName() == "General/ChipErrorPlots")) {
if ((((std::string)mo->getName()).find("General/LinkErrorPlots") != std::string::npos) || (mo->getName() == "General/ChipErrorPlots")) {
auto* h = dynamic_cast<TH1D*>(mo->getObject());
if (h == nullptr) {
ILOG(Error, Support) << "could not cast LinkErrorPlots to TH1D*" << ENDM;
Expand Down
Loading