Common: customize ratio plot draw option in ReferenceComparator #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the histograms are drawn with error bars ("E" option), however
there are cases where the user might want to hide the errors and draw
the histograms with the "H" option, for example because the error bars
are unreliable or unphysical.
This can already be done by passing a custom draw option via the task
configuration interface.
However, the customized draw option is only passed to the current and
reference histograms, but not to the ratio plot, which is always drawn
with the "E" option.
The commit extends the custom draw option also to the ratio histogram.
aferrero2707
requested review from
Barthelemy,
justonedev1 and
knopers8
as code owners
Contributor
Author
|
@Barthelemy @knopers8 @justonedev1 here is a small customization improvement for the reference comparison plots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the histograms are drawn with error bars ("E" option), however there are cases where the user might want to hide the errors and draw the histograms with the "H" option, for example because the error bars are unreliable or unphysical.
This can already be done by passing a custom draw option via the task configuration interface.
However, the customized draw option is only passed to the current and reference histograms, but not to the ratio plot, which is always drawn with the "E" option.
The commit extends the custom draw option also to the ratio histogram.
Here is a practical example: