Skip to content

TPC PID: attempt to avoid occasional TMinuit errors #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehellbar wants to merge 2 commits into from
Closed

TPC PID: attempt to avoid occasional TMinuit errors #2604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
148dd3d
GLO VTX: move fitting outside of the histogram filling loop
ehellbar Aug 22, 2025
94b28ee
TPC PID: attempt to avoid occasional TMinuit errors
ehellbar Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modules/GLO/src/VertexingQcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,7 @@ void VertexingQcTask::monitorData(o2::framework::ProcessingContext& ctx)
auto timeUnc = pvertices[i].getTimeStamp().getTimeStampError();
ILOG(Debug, Support) << "x = " << x << ", y = " << y << ", z = " << z << ", nContributors = " << nContr << ", timeUnc = " << timeUnc << ENDM;
mX->Fill(x);
mX->Fit("fX", "Q", "", mX->GetMean() - mX->GetRMS(), mX->GetMean() + mX->GetRMS());
mY->Fill(y);
mY->Fit("fY", "Q", "", mY->GetMean() - mY->GetRMS(), mY->GetMean() + mY->GetRMS());
mZ->Fill(z);
mNContributors->Fill(nContr);
mTimeUncVsNContrib->Fill(nContr, timeUnc);
Expand All @@ -233,6 +231,8 @@ void VertexingQcTask::monitorData(o2::framework::ProcessingContext& ctx)
mVtxPullsZVsMult->Fill(mult, (vtMC[2] - pvertices[i].getZ()) / std::sqrt(pvertices[i].getSigmaZ2()));
}
}
mX->Fit("fX", "Q", "", mX->GetMean() - mX->GetRMS(), mX->GetMean() + mX->GetRMS());
mY->Fit("fY", "Q", "", mY->GetMean() - mY->GetRMS(), mY->GetMean() + mY->GetRMS());
}

void VertexingQcTask::endOfCycle()
Expand Down
2 changes: 1 addition & 1 deletion Modules/TPC/src/PID.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ void PID::endOfCycle()
fitFunc.SetParameter(5, 10); // Sigma of the second Gaussian

// Fit the histogram with the fitting function
hist->Fit(&fitFunc, "QRN");
hist->Fit(&fitFunc, "QRNM");

const TString binLabels[8] = { "Amplitude Pi", "Mean Pi", "Sigma Pi", "Amplitude El", "Mean El", "Sigma El", "Separation Power", "chiSquare/ndf" };

Expand Down