Partial voice support && CI enchantments#30
Open
cborac wants to merge 57 commits intoAlon-L:masterfrom
Open
Conversation
To strict eslint rules, I've added vscode rules too
Client can only receive sounds but not send right now
I just realised .idea is ignored by .gitignore, if its ignored this should be too
Other one is outdated
Otherwise it caused errors
since its already compiled it wont need to be recompiled there.
The installing duration decreases significantly.
Forgot to checkout
async/await isnt supported below and in the compiled files there are many useless functions
opcode 2 is identify
The reason behind this is local testing. When you try to run npm build, it will give you a dist folder, but if you run ci:build it will give you a lib folder
Contributor
Author
|
Dont ask why did I closed and reopened this, it was an accident |
Contributor
Author
|
Ok adding the dist folder in source code isnt a great idea |
Contributor
Author
|
Please accept this 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial voice support:
NOTE: User must install opusscript and sodium-native to use it
CI enchantments:
NOTE: Contributors must not commit the changes on the lib file (To avoid stupid merge conflicts)
Optional Dependencies:
Variable 'optional package name' implicitly has type 'any' in some locations where its type cannot be determinederror on the optional package imports.Example
Example of usage of the voice support, install the speaker package and run it. type
!joinin chat, it will join the vc, talk in the vc, you'll be able to here your self