Merged
Conversation
The previous way of passing AML methods was restricted to "method header" and "method body". This exists to interface with iasl's output. Instead, the new `aml_method_part` struct can encompass multiple aml sections of code.
The sleep hooks (_PTS and SetVariable) override the waking vector to point to core, but they also need to store the original waking vector so core can return back to the kernel when it's done. Ideally we'd want to directly store the waking vector inside core's header, but it doesn't seem to be mapped for the AML VM, so the _PTS hook can't reach it. It might also not be available to the UEFI Runtime Services environment, but I haven't checked that. Instead, we can use the second reserved field in the FACS table, which is 24-bytes long. We use the beginning of this field to store the original waking vector, and then retrieve it in core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16