Feature/1.6.3patch #1
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the scheduler logic to improve how pods are assigned to nodepools, particularly when multiple nodepools have the same weight. Now, the scheduler will select the nodepool that can provision the cheapest compatible instance type among those with the highest weight, leading to more cost-effective scheduling decisions. The changes include a new flexible scheduling method, an updated test to verify this behavior, and improved documentation.
Scheduler Logic Improvements:
addToNewNodeClaimFlexiblemethod inscheduler.gothat, when creating a new node claim, evaluates all compatible nodepools, and among those with the highest weight, selects the one offering the cheapest instance type for the pod. This replaces the previous approach that only considered nodepool order. [1] [2]provisioner.goto clarify that nodepools are ordered by weight, and within the same weight, the scheduler chooses the cheapest instance type.Testing Enhancements:
instance_selection_test.goto verify that, when multiple nodepools have the same weight, the scheduler correctly selects the cheapest instance.metav1to support the new test.