Skip to content

fix atmosphere somewhat when zooming far out (there is still atmoshpe… #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adam-ce merged 1 commit into from
Nov 8, 2025
Merged

fix atmosphere somewhat when zooming far out (there is still atmoshpe… #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions gl_engine/shaders/compose.frag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ highp float calculate_falloff(highp float dist, highp float from, highp float to
return clamp(1.0 - (dist - from) / (to - from), 0.0, 1.0);
}

highp float calculate_atmospheric_falloff(highp float dist, highp float camera_cos, highp float from, highp float to) {
// return clamp(1.0 - (dist - from) / (to - from), 0.0, 1.0);
return clamp(1.0 - (dist - from) / (to - from), camera_cos, 1.0);
}

#include "atmosphere_implementation.glsl"
#include "encoder.glsl"
#include "shared_config.glsl"
Expand Down Expand Up @@ -157,7 +162,6 @@ void main() {
highp float dist = pos_dist.w; // negative if sky
// Alpha-Value for Tile-Overlay (distant linear falloff)
lowp float alpha = 0.0;
if (dist > 0.0) alpha = calculate_falloff(dist, 300000.0, 600000.0);

highp vec3 normal = octNormalDecode2u16(texture(texin_normal, texcoords).xy);

Expand All @@ -174,8 +178,8 @@ void main() {
highp vec3 pos_ws = pos_cws + origin;
highp vec3 ray_direction = pos_cws / dist;
highp vec4 material_light_response = conf.material_light_response;
alpha = calculate_atmospheric_falloff(dist, -ray_direction.z, 300000.0, 600000.0);

highp vec3 light_through_atmosphere = calculate_atmospheric_light(origin / 1000.0, ray_direction, dist / 1000.0, albedo, 10);

highp float shadow_term = 0.0;
if (bool(conf.csm_enabled)) {
Expand Down