Added an endpoint to add coins to the clan #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rop unnecessary dependencies from the shop module.
…e. Fix failed tests.
MikhailDeriabin
changed the title
src/clan/dto/updateClan.dto.ts
Outdated
| @IsEnum(Language) | ||
| @IsOptional() | ||
| language?: Language; | ||
|
|
Collaborator
There was a problem hiding this comment.
This field can not be here, because that means that the gameCoins can be updated straight from the /clan PUT endpoint.
Collaborator
Author
There was a problem hiding this comment.
Indeed, that's the job of the /clan PUT endpoint to update the clan properties :)
Anyway, I dropped the extra feature...
PlayJeri
requested changes
May 21, 2025
Member
PlayJeri
left a comment
PlayJeri
left a comment
There was a problem hiding this comment.
I think the DTOs shouldn't ask for information that gets overwritten. So consider removing the clan id from dto and use different params for the service method. And in the service method it is unnecessary to read the clan from db. You can directly increment the coins using the $inc operator.
MikhailDeriabin
deleted the
feature/add-a-endpoint-to-add-coins-to-the-clan-550
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Add a endpoint to add coins to the clan
Change list